fix(ngUpgrade): make AoT ngUpgrade work with the testability API and resumeBootstrap() #12910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjelin
force-pushed
the
static-upgrade
branch
2 times, most recently
from
eeddddb
to
176a89f
Compare
…resumeBootstrap()
sjelin
force-pushed
the
static-upgrade
branch
from
176a89f
to
07a220a
Compare
petebacondarwin
approved these changes
Nov 16, 2016
There was a problem hiding this comment.
This looks great, @sjelin! Thanks for staying up late and putting this together.
| @@ -59,7 +91,22 @@ export class UpgradeModule { | |||
| } | |||
| ]); | |||
|
|
|||
| // Make sure resumeBootstrap() only exists if the current bootstrap is deferred | |||
| const windowAngular = (window as any /** TODO #???? */)['angular']; | |||
There was a problem hiding this comment.
I think this is a valid use of any so no need for the TODO comment
petebacondarwin
added
comp: upgrade
type: bug/fix
freq3: high
action: merge
|
I can confirm that this fixes the problem with #12717 |
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this pull request
Nov 16, 2016
…resumeBootstrap() (angular#12910)
sjelin
added a commit
to sjelin/angular
that referenced
this pull request
Nov 16, 2016
…tstrap * With non-static ngUpgrade apps, callbacks to `whenStable` were being invoked with the wrong context * With non-static ngUpgrade apps, `resumeBootstrap` was being run outside the NgZone * Remove redundent `whenStableContext` variable Neither of the above problems with non-static apps were actually causing bugs (as far as I know), but they *might* have caused problems in the future. Inspired by angular#12910, but for non-static apps.
sjelin
added a commit
to sjelin/angular
that referenced
this pull request
Nov 16, 2016
…tstrap * With non-static ngUpgrade apps, callbacks to `whenStable` were being invoked with the wrong context * With non-static ngUpgrade apps, `resumeBootstrap` was being run outside the NgZone * Remove redundent `whenStableContext` variable * Updated static example to get type mocks for ng1 Neither of the first twp problems were actually causing bugs (as far as I know), but they *might* have caused problems in the future. The example had to be updated to make the tests pass (no idea why this change mattered). Inspired by angular#12910, but for non-static apps.
sjelin
added a commit
to sjelin/angular
that referenced
this pull request
Nov 16, 2016
…tstrap * With non-static ngUpgrade apps, callbacks to `whenStable` were being invoked with the wrong context * With non-static ngUpgrade apps, `resumeBootstrap` was being run outside the NgZone * Remove redundent `whenStableContext` variable * Updated static example to get type mocks for ng1 Neither of the first two problems were actually causing bugs (as far as I know), but they *might* have caused problems in the future. The example had to be updated to make the tests pass (no idea why this change mattered to that example). Inspired by angular#12910, but for non-static apps.
3 tasks
sjelin
added a commit
to sjelin/angular
that referenced
this pull request
Nov 16, 2016
…tstrap * With non-static ngUpgrade apps, callbacks to `whenStable` were being invoked with the wrong context * With non-static ngUpgrade apps, `resumeBootstrap` was being run outside the NgZone * Remove redundent `whenStableContext` variable * Updated static example to get type mocks for ng1 Neither of the first two problems were actually causing bugs (as far as I know), but they *might* have caused problems in the future. The example had to be updated to make the tests pass (no idea why this change mattered to that example). Inspired by angular#12910, but for non-static apps.
sjelin
added a commit
to sjelin/angular
that referenced
this pull request
Nov 16, 2016
…tstrap * With non-static ngUpgrade apps, callbacks to `whenStable` were being invoked with the wrong context * With non-static ngUpgrade apps, `resumeBootstrap` was being run outside the NgZone * Remove redundent `whenStableContext` variable Neither of the first two problems were actually causing bugs (as far as I know), but they *might* have caused problems in the future. Inspired by angular#12910, but for non-static apps.
alexeagle
pushed a commit
to alexeagle/angular
that referenced
this pull request
Nov 17, 2016
…resumeBootstrap() (angular#12910)
chuckjaz
pushed a commit
that referenced
this pull request
Nov 18, 2016
…tstrap (#12926) * With non-static ngUpgrade apps, callbacks to `whenStable` were being invoked with the wrong context * With non-static ngUpgrade apps, `resumeBootstrap` was being run outside the NgZone * Remove redundent `whenStableContext` variable Neither of the first two problems were actually causing bugs (as far as I know), but they *might* have caused problems in the future. Inspired by #12910, but for non-static apps.
chuckjaz
pushed a commit
that referenced
this pull request
Nov 22, 2016
…tstrap (#12926) * With non-static ngUpgrade apps, callbacks to `whenStable` were being invoked with the wrong context * With non-static ngUpgrade apps, `resumeBootstrap` was being run outside the NgZone * Remove redundent `whenStableContext` variable Neither of the first two problems were actually causing bugs (as far as I know), but they *might* have caused problems in the future. Inspired by #12910, but for non-static apps.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
In apps using
ngUpgradeand AoT compilation,resumeBootstrapcausesconfigandrunblocks to be run outsideNgZone, which in turn causes problems with change detection. Additionally, the testability APIs of ng1 and ng2 were not hooked together properly.What is the new behavior?
resumeBootstrapis patched to always run inside theNgZone, ng1 testability API is decorated to wait on the ng2 API.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
I have no idea why the second test in
modules/@angular/upgrade/test/aot/integration/testability_spec.tswas passing but I verified using a sample app that the decoration of the ng1 testability API was nessisary