Skip to content

Conversation

wardbell
Copy link
Contributor

Replaces iterator facade over the HeroService because webpack threw up.
Also this was an obscure distraction for readers with no obvious benefits.
This is a pure refactor (with prose). The examples should behave exactly as before.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix (fixed by the refactor)
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

@mary-poppins
Copy link

You can preview 7b881c5 at https://pr18965-7b881c5.ngbuilds.io/.

@wardbell wardbell force-pushed the docs-animations-replace-iterator branch from 7b881c5 to 4a6a16d Compare August 31, 2017 00:14
@mary-poppins
Copy link

You can preview 4a6a16d at https://pr18965-4a6a16d.ngbuilds.io/.

@wardbell wardbell force-pushed the docs-animations-replace-iterator branch from 4a6a16d to 55a50dd Compare August 31, 2017 00:52
@mary-poppins
Copy link

You can preview 55a50dd at https://pr18965-55a50dd.ngbuilds.io/.

@Foxandxss
Copy link
Member

One petition @wardbell. In the big template file where all other components are loaded, there are a few [heroes]=heroes. Notice, no quotes. Can you add them?

Replaces iterator facade over the HeroService because webpack threw up.
Also this was an obscure distraction for readers with no obvious benefits.
@wardbell wardbell force-pushed the docs-animations-replace-iterator branch from 55a50dd to 6dca1f7 Compare August 31, 2017 17:07
@wardbell wardbell added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 15, 2017
@IgorMinar IgorMinar closed this in 5751865 Sep 20, 2017
IgorMinar pushed a commit to IgorMinar/angular that referenced this pull request Sep 21, 2017
…8965)

Replaces iterator facade over the HeroService because webpack threw up.
Also this was an obscure distraction for readers with no obvious benefits.

PR Close angular#18965
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants