Futher fixes for G3 #18986
Futher fixes for G3 #18986
Conversation
|
You can preview 18416e2 at https://pr18986-18416e2.ngbuilds.io/. |
tbosch
force-pushed
the
fix_g3_3
branch
2 times, most recently
from
f82e083 to
a3d19d7
Compare
|
You can preview a3d19d7 at https://pr18986-a3d19d7.ngbuilds.io/. |
|
You can preview d728a0b at https://pr18986-d728a0b.ngbuilds.io/. |
|
You can preview 496644a at https://pr18986-496644a.ngbuilds.io/. |
| @@ -106,6 +106,7 @@ def _compile_action(ctx, inputs, outputs, config_file_path): | |||
| if hasattr(ctx.attr, "tsconfig") and ctx.file.tsconfig: | |||
| action_inputs += [ctx.file.tsconfig] | |||
|
|
|||
| arguments = ["--node_options=--expose-gc"] | |||
| # One at-sign makes this a params-file, enabling the worker strategy. | |||
| # Two at-signs escapes the argument so it's passed through to ngc | |||
| # rather than the contents getting expanded. | |||
| } | ||
|
|
||
| export function compile( | ||
| {fileLoader, compilerOpts, bazelOpts, files, expectedOuts, gatherDiagnostics}: { |
There was a problem hiding this comment.
are you sure about taking named parameters here? so clunky
There was a problem hiding this comment.
Yes. This is way easier to read on the call site than to take all of these as positional arguments. We have it in the ngc api as well. And chuck also complained about it :-)
| @@ -28,6 +28,11 @@ describe('Expression lowering', () => { | |||
| class MyClass {} | |||
| `)).toContain('const l = () => null; exports.l = l;'); | |||
| }); | |||
|
|
|||
| it('should be able to export a variable if the whole value is lowered', () => { | |||
| expect(convert('/*a*/ const a =◊b: () => null◊;')) | |||
There was a problem hiding this comment.
weird diamond characters appear on github web ui :(
There was a problem hiding this comment.
Yes, that is on purpose. See the other tests.
|
You can preview a8d9597 at https://pr18986-a8d9597.ngbuilds.io/. |
|
You can preview c1ca788 at https://pr18986-c1ca788.ngbuilds.io/. |
|
You can preview 1dda6ce at https://pr18986-1dda6ce.ngbuilds.io/. |
…flexible Needed to allow custom checking for diagnostics.
This e.g. leaves comments at the right place, which is important for closure.
|
You can preview 4b3cbb3 at https://pr18986-4b3cbb3.ngbuilds.io/. |
tbosch
added
action: merge
|
Landed as a69172f |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.