fix(compiler): emit correct type-check-blocks with TemplateRef's #20463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type-check block generated with `"fullTemplateTypeCheck"` was invalid if the it contained a template ref as would be generated using the `else` micro-syntax of `NgIf`. Fixes: angular#19485
|
You can preview 5244ac9 at https://pr20463-5244ac9.ngbuilds.io/. |
mhevery
approved these changes
Nov 15, 2017
chuckjaz
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type-check block generated with
"fullTemplateTypeCheck"wasinvalid if the it contained a template ref as would be generated
using the
elsemicro-syntax ofNgIf.Fixes: #19485
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #19485
What is the new behavior?
The type-check blocks are now valid if they contain a generated template ref.
Does this PR introduce a breaking change?