Skip to content

docs: edit styleguide recommendation on components as elements #22074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

docs: edit styleguide recommendation on components as elements #22074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions aio/content/guide/styleguide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3773,8 +3773,7 @@ A typical *lazy loaded folder* contains a *routing component*, its child compone
<div class="s-rule do">



**Do** give components an _element_ selector, as opposed to _attribute_ or _class_ selectors.
**Consider** giving components an _element_ selector, as opposed to _attribute_ or _class_ selectors.


</div>
Expand Down Expand Up @@ -3803,7 +3802,11 @@ Developers place components on the page as they would native HTML elements and w

</div>

<div class="l-sub-section">

There are a few cases where you give a component an attribute, such as when you want to augment a built-in element. For example, [Material Design](https://material.angular.io/components/button/overview) uses this technique with `<button mat-button>`. However, you wouldn't use this technique on a custom element.

</div>

<code-example path="styleguide/src/05-03/app/heroes/shared/hero-button/hero-button.component.avoid.ts" region="example" title="app/heroes/hero-button/hero-button.component.ts">

Expand All @@ -3819,8 +3822,6 @@ Developers place components on the page as they would native HTML elements and w





<code-tabs>

<code-pane title="app/heroes/shared/hero-button/hero-button.component.ts" path="styleguide/src/05-03/app/heroes/shared/hero-button/hero-button.component.ts" region="example">
Expand Down