New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support metadata reflection for native class types #22356

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@vicb
Contributor

vicb commented Feb 21, 2018

closes #21731

supersedes #22315 (rebased version).

Original PR has all required approval for merging.

@googlebot

This comment has been minimized.

googlebot commented Feb 21, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@ngbot

This comment has been minimized.

ngbot bot commented Feb 21, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required labels: "PR target: *", "cla: yes"
    failure forbidden label detected: cla: no
    failure status "cla/google" is failing
    pending status "code-review/pullapprove" is pending
    pending status "ci/circleci: lint" is pending
    pending status "ci/circleci: build" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 21, 2018

@mary-poppins

This comment has been minimized.

mary-poppins commented Feb 22, 2018

vicb added a commit that referenced this pull request Feb 22, 2018

@vicb vicb closed this in 5c89d6b Feb 22, 2018

vicb added a commit that referenced this pull request Feb 22, 2018

vicb added a commit that referenced this pull request Feb 22, 2018

jbogarthyde added a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018

smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018

smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018

smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018

@vicb vicb deleted the vicb:gh-22315 branch Mar 6, 2018

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

@trotyl

This comment has been minimized.

Contributor

trotyl commented May 9, 2018

Just got that base class doesn't have to be an IdentifierName but whatever expression, for example a webpack dev build would generate:

class Derived extends _some__WEBPACK_IMPORTED_MODULE_1__["Base"] {
    constructor() {
        super(...arguments);
    }
}

And this won't work then. But should be OK for production in favor of scope hoisting.

Seems this check should be deprecated as per #22642 comes, I'm not sure whether it should be fixed.

DevVersion added a commit to DevVersion/material2 that referenced this pull request Aug 20, 2018

fix(table): not rendering properly in es2015 apps
Fixes that the table does not render properly when used inside of a ES2015 application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class.

* angular/angular#22642
* angular/tsickle#760

Fixes angular#9329

DevVersion added a commit to DevVersion/material2 that referenced this pull request Aug 20, 2018

fix: ensure components work with ES2015 in jit mode.
Fixes that some components does not render properly when used inside of a ES2015 JIT application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class.

* angular/angular#22642
* angular/tsickle#760

See the more detailed issue here: angular#12760

Fixes angular#9329.

jelbourn added a commit to angular/material2 that referenced this pull request Aug 21, 2018

fix: ensure components work with ES2015 in jit mode. (#12759)
Fixes that some components does not render properly when used inside of a ES2015 JIT application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class.

* angular/angular#22642
* angular/tsickle#760

See the more detailed issue here: #12760

Fixes #9329.

jelbourn added a commit to angular/material2 that referenced this pull request Aug 29, 2018

fix: ensure components work with ES2015 in jit mode. (#12759)
Fixes that some components does not render properly when used inside of a ES2015 JIT application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class.

* angular/angular#22642
* angular/tsickle#760

See the more detailed issue here: #12760

Fixes #9329.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment