Skip to content

build: upgrade to TypeScript 2.7 #22669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

build: upgrade to TypeScript 2.7 #22669

wants to merge 6 commits into from

Conversation

IgorMinar
Copy link
Contributor

Fixes: #21571
Closes: #22097

@mary-poppins
Copy link

You can preview 888b55b at https://pr22669-888b55b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 589c2c8 at https://pr22669-589c2c8.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 141d8a6 at https://pr22669-141d8a6.ngbuilds.io/.

@IgorMinar IgorMinar force-pushed the pr/22097-typescript-2.7 branch from 141d8a6 to 2114b20 Compare March 9, 2018 04:57
@mary-poppins
Copy link

You can preview 2114b20 at https://pr22669-2114b20.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 2ea77b9 at https://pr22669-2ea77b9.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a8b7a9d at https://pr22669-a8b7a9d.ngbuilds.io/.

@mary-poppins
Copy link

You can preview d3a99d8 at https://pr22669-d3a99d8.ngbuilds.io/.

@IgorMinar IgorMinar force-pushed the pr/22097-typescript-2.7 branch from d3a99d8 to 2027ec8 Compare March 9, 2018 18:01
@mary-poppins
Copy link

You can preview 2027ec8 at https://pr22669-2027ec8.ngbuilds.io/.

@kara kara added type: bug/fix area: build & ci Related the build and CI infrastructure of the project refactoring Issue that involves refactoring or code-cleanup and removed type: bug/fix labels Mar 9, 2018
@IgorMinar IgorMinar force-pushed the pr/22097-typescript-2.7 branch from 2027ec8 to f47bace Compare March 10, 2018 00:40
@mary-poppins
Copy link

You can preview f47bace at https://pr22669-f47bace.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 5ede4a7 at https://pr22669-5ede4a7.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 78a1998 at https://pr22669-78a1998.ngbuilds.io/.

@IgorMinar IgorMinar force-pushed the pr/22097-typescript-2.7 branch from 78a1998 to 0956037 Compare March 10, 2018 02:36
@mary-poppins
Copy link

You can preview 0956037 at https://pr22669-0956037.ngbuilds.io/.

@IgorMinar IgorMinar force-pushed the pr/22097-typescript-2.7 branch from 23ae723 to 780ca3e Compare March 10, 2018 05:02
@mary-poppins
Copy link

You can preview 23ae723 at https://pr22669-23ae723.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 780ca3e at https://pr22669-780ca3e.ngbuilds.io/.

@IgorMinar IgorMinar force-pushed the pr/22097-typescript-2.7 branch 2 times, most recently from e9e4963 to c4eca74 Compare March 10, 2018 05:42
@mary-poppins
Copy link

You can preview e9e4963 at https://pr22669-e9e4963.ngbuilds.io/.

@mary-poppins
Copy link

You can preview c4eca74 at https://pr22669-c4eca74.ngbuilds.io/.

@IgorMinar IgorMinar force-pushed the pr/22097-typescript-2.7 branch from c4eca74 to 783eb01 Compare March 10, 2018 06:17
@mary-poppins
Copy link

You can preview 783eb01 at https://pr22669-783eb01.ngbuilds.io/.

@IgorMinar IgorMinar added the target: major This PR is targeted for the next major release label Mar 11, 2018
@IgorMinar
Copy link
Contributor Author

IgorMinar commented Mar 12, 2018 •
edited
Loading

Caretaker note: TAP is now passing but I can't push the commit status to this PR right now! https://test.corp.google.com/ui#id=OCL:188670023:BASE:188670926:1520822633851:ceb2701a

alexeagle
alexeagle approved these changes Mar 12, 2018
View reviewed changes
packages/core/testing/src/render3.ts
@@ -41,7 +41,10 @@ export function withBody<T>(html: string, blockFn: T): T {
let returnValue: any = undefined;
if (typeof blockFn === 'function') {
document.body.innerHTML = html;
let blockReturn = blockFn();
// TODO(i): I'm not sure why a cast is required here but otherwise I get
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean to replace (i) with something else?

packages/service-worker/worker/testing/fetch.ts
url: string;

constructor(input: string|Request, init: RequestInit = {}) {
super(init !== undefined ? init.body || null : null);
super(init !== undefined ? (init.body as(string | null)) || null : null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do some of these casts need TODOs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the casts to any should be eventually removed, but I'd rather add a tslint rule to fend those off than more todos.

packages/core/src/render3/interfaces/definition.ts
@@ -218,7 +218,7 @@ export interface DirectiveDefArgs<T> {
/**
* Factory method used to create an instance of directive.
*/
factory: () => T | [T];
factory: () => T | ({0: T} & any[]); /* trying to say T | [T, ...any] */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO?

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 12, 2018
@kara kara closed this in 129d1e0 Mar 12, 2018
kara pushed a commit that referenced this pull request Mar 12, 2018
@IgorMinar @kara
build: introduce a temporary patch to make node_modules/rxjs compile …
a225b48 
…with typescript 2.7 (#22669)

This patch can be removed once we update to rxjs v6. See #22573.

PR Close #22669
kara pushed a commit that referenced this pull request Mar 12, 2018
@chuckjaz @kara
build: upgrade to TypeScript 2.7 (#22669)
8449eb8 
Fixes: #21571

PR Close #22669
kara pushed a commit that referenced this pull request Mar 12, 2018
@IgorMinar @kara
feat(compiler-cli): require node 8 as runtime engine (#22669)
c602563 
This is not expected to be a breaking change for anyone who's on Node LTS (currently v8)
and aligns @angular/compilar-cli with @angular/cli's runtime requirements.

PR Close #22669
kara pushed a commit that referenced this pull request Mar 12, 2018
@IgorMinar @kara
build: switch from uglify-js to uglify-es (#22669)
eb6fb2d 
This enables us to minify ES2015 code.

PR Close #22669
kara pushed a commit that referenced this pull request Mar 12, 2018
@IgorMinar @kara
fix(compiler-cli): disableTypeScriptVersionCheck should be applied ev…
3f70aba 
…en for older tsc versions (#22669)

Previously the flag would only disable the check in the case we tried to use newer tsc version.

In g3 we sometimes take a while to update tsc, but as a prerequisite of that Angular needs to be
updated first. This change enables us to update Angular and use it in g3 while g3 is being update
to the required tsc. Of course extra care is required when this check is disabled, but since we
control everything in g3, it's on us to get this right.

I don't see any preexisting tests for this, and I'm not sure how to write them right now.
I filed #22699

PR Close #22669
@chuckjaz chuckjaz mentioned this pull request Mar 12, 2018
Closed
@jasonaden jasonaden mentioned this pull request Mar 20, 2018
Closed
jasonaden added a commit to jasonaden/angular that referenced this pull request Mar 20, 2018
@jasonaden
fix(router): make locationSyncBootstrapListener public due to change …
37a5d18 
…in output after TS 2.7 update in angular#22669
jasonaden added a commit to jasonaden/angular that referenced this pull request Mar 20, 2018
@jasonaden
fixup! fix(router): make locationSyncBootstrapListener public due to …
86e68b1 
…change in output after TS 2.7 update in angular#22669
IgorMinar pushed a commit that referenced this pull request Mar 21, 2018
@jasonaden @IgorMinar
fix(router): make locationSyncBootstrapListener public due to change …
623d769 
…in output after TS 2.7 update in #22669 (#22896)

PR Close #22896
@IgorMinar IgorMinar mentioned this pull request May 8, 2018
Closed
7 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@alexeagle alexeagle alexeagle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript 2.7 support
6 participants
@IgorMinar @mary-poppins @alexeagle @kara @googlebot @chuckjaz