Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to TypeScript 2.7 #22669

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
6 participants
@IgorMinar
Copy link
Member

commented Mar 9, 2018

Fixes: #21571
Closes: #22097

@googlebot googlebot added the cla: yes label Mar 9, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 9, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 9, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 9, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:pr/22097-typescript-2.7 branch from 141d8a6 to 2114b20 Mar 9, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 9, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 9, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 9, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 9, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:pr/22097-typescript-2.7 branch from d3a99d8 to 2027ec8 Mar 9, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 9, 2018

You can preview 2027ec8 at https://pr22669-2027ec8.ngbuilds.io/.

@IgorMinar IgorMinar force-pushed the IgorMinar:pr/22097-typescript-2.7 branch from 2027ec8 to f47bace Mar 10, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 10, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 10, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 10, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:pr/22097-typescript-2.7 branch from 78a1998 to 0956037 Mar 10, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 10, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:pr/22097-typescript-2.7 branch from 23ae723 to 780ca3e Mar 10, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 10, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 10, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:pr/22097-typescript-2.7 branch 2 times, most recently from e9e4963 to c4eca74 Mar 10, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 10, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 10, 2018

@IgorMinar IgorMinar force-pushed the IgorMinar:pr/22097-typescript-2.7 branch from c4eca74 to 783eb01 Mar 10, 2018

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 10, 2018

@@ -13,7 +13,7 @@
},
"peerDependencies": {
"@angular/compiler-cli": "0.0.0-PLACEHOLDER",
"typescript": ">=2.4.2 <2.7"
"typescript": ">=2.7.2 <2.8"

This comment has been minimized.

Copy link
@alexeagle

alexeagle Mar 10, 2018

Contributor

Hmm I wonder if we need to do something with @bazel/typescript too - it's tied to be the same version as google3. But if the integration/bazel test passes, that should be sufficient...

This comment has been minimized.

Copy link
@IgorMinar

IgorMinar Mar 10, 2018

Author Member

yeah. the whole setup is a bit finicky during this transitional period. but if we get all the tests to pass unmodified and g3 is green then we should have enough coverage to land this. I'm fine with this since the situation is temporary.

@IgorMinar

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2018

g3 tap is passing with the exception of i18n extraction tests. I need to see what's up with those: https://test.corp.google.com/ui#id=OCL:188563492:BASE:188608973:1520710704825:cb5c9864

@IgorMinar

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2018

Caretaker note: TAP is now passing but I can't push the commit status to this PR right now! https://test.corp.google.com/ui#id=OCL:188670023:BASE:188670926:1520822633851:ceb2701a

@@ -41,7 +41,10 @@ export function withBody<T>(html: string, blockFn: T): T {
let returnValue: any = undefined;
if (typeof blockFn === 'function') {
document.body.innerHTML = html;
let blockReturn = blockFn();
// TODO(i): I'm not sure why a cast is required here but otherwise I get

This comment has been minimized.

Copy link
@alexeagle

alexeagle Mar 12, 2018

Contributor

do you mean to replace (i) with something else?

url: string;

constructor(input: string|Request, init: RequestInit = {}) {
super(init !== undefined ? init.body || null : null);
super(init !== undefined ? (init.body as(string | null)) || null : null);

This comment has been minimized.

Copy link
@alexeagle

alexeagle Mar 12, 2018

Contributor

do some of these casts need TODOs?

This comment has been minimized.

Copy link
@IgorMinar

IgorMinar Mar 12, 2018

Author Member

I think the casts to any should be eventually removed, but I'd rather add a tslint rule to fend those off than more todos.

@@ -218,7 +218,7 @@ export interface DirectiveDefArgs<T> {
/**
* Factory method used to create an instance of directive.
*/
factory: () => T | [T];
factory: () => T | ({0: T} & any[]); /* trying to say T | [T, ...any] */

This comment has been minimized.

Copy link
@alexeagle

alexeagle Mar 12, 2018

Contributor

TODO?

@kara kara closed this in 129d1e0 Mar 12, 2018

kara added a commit that referenced this pull request Mar 12, 2018

build: introduce a temporary patch to make node_modules/rxjs compile …
…with typescript 2.7 (#22669)

This patch can be removed once we update to rxjs v6. See #22573.

PR Close #22669

kara added a commit that referenced this pull request Mar 12, 2018

kara added a commit that referenced this pull request Mar 12, 2018

feat(compiler-cli): require node 8 as runtime engine (#22669)
This is not expected to be a breaking change for anyone who's on Node LTS (currently v8)
and aligns @angular/compilar-cli with @angular/cli's runtime requirements.

PR Close #22669

kara added a commit that referenced this pull request Mar 12, 2018

build: switch from uglify-js to uglify-es (#22669)
This enables us to minify ES2015 code.

PR Close #22669

kara added a commit that referenced this pull request Mar 12, 2018

fix(compiler-cli): disableTypeScriptVersionCheck should be applied ev…
…en for older tsc versions (#22669)

Previously the flag would only disable the check in the case we tried to use newer tsc version.

In g3 we sometimes take a while to update tsc, but as a prerequisite of that Angular needs to be
updated first. This change enables us to update Angular and use it in g3 while g3 is being update
to the required tsc. Of course extra care is required when this check is disabled, but since we
control everything in g3, it's on us to get this right.

I don't see any preexisting tests for this, and I'm not sure how to write them right now.
I filed #22699

PR Close #22669

jasonaden added a commit to jasonaden/angular that referenced this pull request Mar 20, 2018

jasonaden added a commit to jasonaden/angular that referenced this pull request Mar 20, 2018

jasonaden added a commit to jasonaden/angular that referenced this pull request Mar 20, 2018

IgorMinar added a commit that referenced this pull request Mar 21, 2018

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build: add postinstall-patches.js script suitable for postinstall pat…
…ching of dependencies (angular#22669)

Because sometimes one has to do what one has to do...

PR Close angular#22669

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build: introduce a temporary patch to make node_modules/rxjs compile …
…with typescript 2.7 (angular#22669)

This patch can be removed once we update to rxjs v6. See angular#22573.

PR Close angular#22669

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

feat(compiler-cli): require node 8 as runtime engine (angular#22669)
This is not expected to be a breaking change for anyone who's on Node LTS (currently v8)
and aligns @angular/compilar-cli with @angular/cli's runtime requirements.

PR Close angular#22669

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build: switch from uglify-js to uglify-es (angular#22669)
This enables us to minify ES2015 code.

PR Close angular#22669

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

fix(compiler-cli): disableTypeScriptVersionCheck should be applied ev…
…en for older tsc versions (angular#22669)

Previously the flag would only disable the check in the case we tried to use newer tsc version.

In g3 we sometimes take a while to update tsc, but as a prerequisite of that Angular needs to be
updated first. This change enables us to update Angular and use it in g3 while g3 is being update
to the required tsc. Of course extra care is required when this check is disabled, but since we
control everything in g3, it's on us to get this right.

I don't see any preexisting tests for this, and I'm not sure how to write them right now.
I filed angular#22699

PR Close angular#22669

leo6104 added a commit to leo6104/angular that referenced this pull request Mar 25, 2018

@IgorMinar IgorMinar referenced this pull request May 8, 2018

Closed

Add support for TypeScript 2.8 #23779

6 of 7 tasks complete

jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.