Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(forms): add updateOn option to FormBuilder #24599
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #19163
What is the new behavior?
Does this PR introduce a breaking change?
Special care has been taken to keep backwards compatibility with the
Unit tests have been massaged from the form control spec.
Thanks for the PR! It's looking great, just one comment (also needs a rebase).
@LayZeeDK Can you take a look at the failing CI test? Looks related to the change: https://travis-ci.org/angular/angular/jobs/418858316.
Also you'll want to lint with
referenced this pull request
Oct 8, 2018
What am I doing wrong?
Alright, the command seems to be
I will try rebasing again and then generate a new golden file.
Please help me out here
I tried it both on Bash, MSYS2, and Ubuntu@Windows Subsystem for Linux.
Thank you for helping me out, @kara! I spent more time wrestling Git, testing tools, and build tools than adding code and tests