Skip to content

test(ivy): update sidenav and drawer root causes #28972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test(ivy): update sidenav and drawer root causes #28972

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Updates the root causes for the MatDrawer and MatSidenav tests. All of the MatDrawer failures were fixed by angular/components#15300.

@crisbeto
test(ivy): update sidenav and drawer root causes
79d387c 
Updates the root causes for the `MatDrawer` and `MatSidenav` tests. All of the `MatDrawer` failures were fixed by angular/components#15300.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer comp: ivy labels Feb 26, 2019
@crisbeto crisbeto requested review from a team as code owners February 26, 2019 08:09
@ngbot ngbot bot added this to the needsTriage milestone Feb 26, 2019
kara
kara approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 26, 2019
@kara
Copy link
Contributor

kara commented Feb 26, 2019

merge-assistance: core approval should be sufficient for this

@benlesh benlesh closed this in dbd9ecf Feb 26, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@kara kara kara approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @kara @googlebot