feat(core): add ability to reflect DOM properties as attributes #3072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbcross
added
feature
| @@ -186,6 +193,11 @@ export class DomRenderer extends Renderer { | |||
| setElementProperty(location: RenderElementRef, propertyName: string, propertyValue: any): void { | |||
| var view = resolveInternalDomView(location.renderView); | |||
| view.setElementProperty(location.boundElementIndex, propertyName, propertyValue); | |||
| // Reflect the property value as an attribute value with ng-reflect- prefix. | |||
| if (this._reflectPropertiesAsAttributes) { | |||
| this.setElementAttribute(location, REFLECT_PREFIX + camelCaseToDashCase(propertyName), | |||
There was a problem hiding this comment.
Use string interpolation
jeffbcross
force-pushed
the
feat-dom-debug
branch
from
bb708d5 to
27ad9f5
Compare
|
@tbosch I made the change to use string interpolation and to unwrap the prefix string literal from CONST_EXPR. Look good? |
|
Reviewed with @tbosch in person and got the LGTM when green. |
jeffbcross
added
pr_state: LGTM
action: merge
By binding the token `DOM_REFLECT_PROPERTIES_AS_ATTRIBUTES` provided by the dom_renderer module to `true` in the root injector (i.e. bootstrap()), all elements whose properties are set by angular will be reflected as attributes with the prefix "ng-reflect-". Fixes angular#2910
jeffbcross
force-pushed
the
feat-dom-debug
branch
from
27ad9f5 to
903ff90
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By binding the token
DOM_REFLECT_PROPERTIES_AS_ATTRIBUTESprovided bythe dom_renderer module to
truein the root injector (i.e. bootstrap()),all elements whose properties are set by angular will be reflected as
attributes with the prefix "ng-reflect-".
Fixes #2910
NOTE: I expect enforce-format to break since it is broken on master right now. @alexeagle is fixing.