feat(i18n): initial `$localize` functionality #31609

petebacondarwin · Jul 17, 2019

~~Blocked on #31943~~

TODOs

For this PR:

fix AOT tests to provide a runtime implementation of $localize
fix material legacy tests to update with @angular/localize etc (perhaps via a migration?)
fix integration tests to update with @angular/localize etc (perhaps via a migration?)

For next PR?

write the update migration schematic
write the new project schematic
write compile-time inliner (Babel plugin/standalone tool)

mhevery · 2019-07-17T16:22:15Z

mhevery approved these changes

Jul 17, 2019

View changes

tsconfig.json

packages/i18n/localize/src/hash.ts

googlebot · Jul 17, 2019

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only "I consent." in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

ocombe · 2019-07-18T08:57:47Z

ocombe approved these changes

Jul 18, 2019

View changes

googlebot · Jul 18, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · Jul 18, 2019

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only "I consent." in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · Jul 18, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.


      feat(ivy): implement `$localize()` global function


      refactor(ivy): update the compiler to emit `$localize` tags

This commit changes the Angular compiler (ivy-only) to generate `$localize`
tagged strings for component templates that use `i18n` attributes.

BREAKING CHANGE

Since `$localize` is a global function, it must be included in any applications
that use i18n. This is achieved by importing the `@angular/localize` package
into an appropriate bundle, where it will be executed before the renderer
needs to call `$localize`. For CLI based projects, this is best done in
the `polyfills.ts` file.

```ts
import '@angular/localize';
```

For non-CLI applications this could be added as a script to the index.html
file or another suitable script file.


      refactor(ivy): remove `i18nLocalize` instruction

This has been replaced by the `$localize` tag.


      docs(core): update the i18n design doc


      refactor(ivy): remove `i18nConfigureLocalize` instruction

This has been replaced by the `loadTranslations()` function in
`@angular/localize/run_time`.


      test(ivy): add cli-hello-world-ivy-i18n integration test

This test uses localization in the `AppComponent` component:

* an `i18n` attribute in the template
* a call to the `$localize` tag in the component constructor


      test: make cli-hello-world-ivy-minimal/debug-test.sh executable

mhevery · Aug 30, 2019

GLOBAL APPROVAL: misko


      feat(ivy): implement `$localize()` global function (#31609)

PR Close #31609


      refactor(ivy): update the compiler to emit `$localize` tags (#31609)

This commit changes the Angular compiler (ivy-only) to generate `$localize`
tagged strings for component templates that use `i18n` attributes.

BREAKING CHANGE

Since `$localize` is a global function, it must be included in any applications
that use i18n. This is achieved by importing the `@angular/localize` package
into an appropriate bundle, where it will be executed before the renderer
needs to call `$localize`. For CLI based projects, this is best done in
the `polyfills.ts` file.

```ts
import '@angular/localize';
```

For non-CLI applications this could be added as a script to the index.html
file or another suitable script file.

PR Close #31609


      refactor(ivy): remove `i18nLocalize` instruction (#31609)

This has been replaced by the `$localize` tag.

PR Close #31609


      refactor(ivy): remove `i18nConfigureLocalize` instruction (#31609)

This has been replaced by the `loadTranslations()` function in
`@angular/localize/run_time`.

PR Close #31609


      docs(core): update the i18n design doc (#31609)

PR Close #31609


      test(ivy): add cli-hello-world-ivy-i18n integration test (#31609)

This test uses localization in the `AppComponent` component:

* an `i18n` attribute in the template
* a call to the `$localize` tag in the component constructor

PR Close #31609


      test: make cli-hello-world-ivy-minimal/debug-test.sh executable (#31609)

PR Close #31609

mhevery · Sep 3, 2019

This needs to be reverted as it breaks g3.

/checkbox_logo.closure.js:47: ERROR - [JSC_UNDEFINED_VARIABLE] variable $localize is undeclared
    I18N_6 = $localize `User portrait`;
             ^^^^^^^^^


      test(common): remove redundant line from karma config (angular#31609)

The files in the pattern do not exist.

PR Close angular#31609


      feat(ivy): implement `$localize()` global function (angular#31609)

PR Close angular#31609


      refactor(ivy): update the compiler to emit `$localize` tags (angular#…

…31609)

This commit changes the Angular compiler (ivy-only) to generate `$localize`
tagged strings for component templates that use `i18n` attributes.

BREAKING CHANGE

Since `$localize` is a global function, it must be included in any applications
that use i18n. This is achieved by importing the `@angular/localize` package
into an appropriate bundle, where it will be executed before the renderer
needs to call `$localize`. For CLI based projects, this is best done in
the `polyfills.ts` file.

```ts
import '@angular/localize';
```

For non-CLI applications this could be added as a script to the index.html
file or another suitable script file.

PR Close angular#31609


      refactor(ivy): remove `i18nLocalize` instruction (angular#31609)

This has been replaced by the `$localize` tag.

PR Close angular#31609


      refactor(ivy): remove `i18nConfigureLocalize` instruction (angular#31609

)

This has been replaced by the `loadTranslations()` function in
`@angular/localize/run_time`.

PR Close angular#31609


      docs(core): update the i18n design doc (angular#31609)

PR Close angular#31609


      test(ivy): add cli-hello-world-ivy-i18n integration test (angular#31609)

This test uses localization in the `AppComponent` component:

* an `i18n` attribute in the template
* a call to the `$localize` tag in the component constructor

PR Close angular#31609


      test: make cli-hello-world-ivy-minimal/debug-test.sh executable (angu…

…lar#31609)

PR Close angular#31609

googlebot added the cla: yes label Jul 17, 2019

petebacondarwin added the PR state: WIP label Jul 17, 2019

petebacondarwin force-pushed the petebacondarwin:i18n-localize-init branch 2 times, most recently from fa4213d to 84eff89 Jul 17, 2019

mhevery added the PR action: cleanup label Jul 17, 2019

googlebot added cla: no and removed cla: yes labels Jul 17, 2019

matsko added the comp: i18n label Jul 17, 2019

ngbot bot added this to the needsTriage milestone Jul 17, 2019

petebacondarwin force-pushed the petebacondarwin:i18n-localize-init branch from dcc05e6 to 78021d4 Jul 18, 2019

googlebot removed the cla: no label Jul 18, 2019

googlebot added cla: no and removed cla: yes labels Jul 18, 2019

petebacondarwin force-pushed the petebacondarwin:i18n-localize-init branch from 0afe5b9 to feec4a8 Jul 18, 2019

googlebot added cla: yes and removed cla: no labels Jul 18, 2019

petebacondarwin marked this pull request as ready for review Jul 18, 2019

petebacondarwin requested review from IgorMinar and angular/fw-dev-infra as code owners Jul 18, 2019

petebacondarwin force-pushed the petebacondarwin:i18n-localize-init branch 2 times, most recently from 0b49661 to 416d8b6 Jul 18, 2019

petebacondarwin added PR action: review and removed PR action: cleanup PR state: WIP labels Jul 18, 2019

petebacondarwin force-pushed the petebacondarwin:i18n-localize-init branch 2 times, most recently from 170920c to be63d9c Aug 30, 2019

petebacondarwin added 7 commits Jul 30, 2019

feat(ivy): implement `$localize()` global function

Loading status checks…

cb0d6f8

refactor(ivy): remove `i18nLocalize` instruction
This has been replaced by the `$localize` tag.

Loading status checks…

d6c4e5d

docs(core): update the i18n design doc

Loading status checks…

7b5119c

refactor(ivy): remove `i18nConfigureLocalize` instruction
This has been replaced by the `loadTranslations()` function in `@angular/localize/run_time`.

Loading status checks…

a17b9d4

test(ivy): add cli-hello-world-ivy-i18n integration test
This test uses localization in the `AppComponent` component: * an `i18n` attribute in the template * a call to the `$localize` tag in the component constructor

Loading status checks…

a767d7d

test: make cli-hello-world-ivy-minimal/debug-test.sh executable

Loading status checks…

3b9909f

petebacondarwin force-pushed the petebacondarwin:i18n-localize-init branch from be63d9c to 3b9909f Aug 30, 2019

mhevery closed this in b34bdf5 Aug 30, 2019

mhevery added a commit that referenced this pull request Aug 30, 2019

feat(ivy): implement `$localize()` global function (#31609)
PR Close #31609

b21397b

mhevery added a commit that referenced this pull request Aug 30, 2019

refactor(ivy): remove `i18nLocalize` instruction (#31609)
This has been replaced by the `$localize` tag. PR Close #31609

c024d89

mhevery added a commit that referenced this pull request Aug 30, 2019

refactor(ivy): remove `i18nConfigureLocalize` instruction (#31609)
This has been replaced by the `loadTranslations()` function in `@angular/localize/run_time`. PR Close #31609

a7f61e6

mhevery added a commit that referenced this pull request Aug 30, 2019

docs(core): update the i18n design doc (#31609)
PR Close #31609

fe5caca

mhevery added a commit that referenced this pull request Aug 30, 2019

test(ivy): add cli-hello-world-ivy-i18n integration test (#31609)
This test uses localization in the `AppComponent` component: * an `i18n` attribute in the template * a call to the `$localize` tag in the component constructor PR Close #31609

8cdfcc5

mhevery added a commit that referenced this pull request Aug 30, 2019

test: make cli-hello-world-ivy-minimal/debug-test.sh executable (#31609)
PR Close #31609

Loading status checks…

9a55eaf

petebacondarwin deleted the petebacondarwin:i18n-localize-init branch Aug 30, 2019

petebacondarwin referenced this pull request Sep 4, 2019

[IVY] i18n not working yet? #32311

Closed