feat(i18n): initial `$localize` functionality #31609

petebacondarwin · 2019-07-17T15:10:19Z

~~Blocked on #31943~~

TODOs

For this PR:

fix AOT tests to provide a runtime implementation of $localize
fix material legacy tests to update with @angular/localize etc (perhaps via a migration?)
fix integration tests to update with @angular/localize etc (perhaps via a migration?)

For next PR?

write the update migration schematic
write the new project schematic
write compile-time inliner (Babel plugin/standalone tool)

tsconfig.json

packages/i18n/localize/src/hash.ts

googlebot · 2019-07-17T16:42:57Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only "I consent." in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2019-07-18T09:34:50Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2019-07-18T14:48:39Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only "I consent." in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2019-07-18T20:24:55Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

mhevery · 2019-08-30T19:33:03Z

GLOBAL APPROVAL: misko

PR Close #31609

This commit changes the Angular compiler (ivy-only) to generate `$localize` tagged strings for component templates that use `i18n` attributes. BREAKING CHANGE Since `$localize` is a global function, it must be included in any applications that use i18n. This is achieved by importing the `@angular/localize` package into an appropriate bundle, where it will be executed before the renderer needs to call `$localize`. For CLI based projects, this is best done in the `polyfills.ts` file. ```ts import '@angular/localize'; ``` For non-CLI applications this could be added as a script to the index.html file or another suitable script file. PR Close #31609

This has been replaced by the `$localize` tag. PR Close #31609

This has been replaced by the `loadTranslations()` function in `@angular/localize/run_time`. PR Close #31609

PR Close #31609

This test uses localization in the `AppComponent` component: * an `i18n` attribute in the template * a call to the `$localize` tag in the component constructor PR Close #31609

PR Close #31609

mhevery · 2019-09-03T16:47:34Z

This needs to be reverted as it breaks g3.

/checkbox_logo.closure.js:47: ERROR - [JSC_UNDEFINED_VARIABLE] variable $localize is undeclared
    I18N_6 = $localize `User portrait`;
             ^^^^^^^^^

The files in the pattern do not exist. PR Close angular#31609

PR Close angular#31609

…31609) This commit changes the Angular compiler (ivy-only) to generate `$localize` tagged strings for component templates that use `i18n` attributes. BREAKING CHANGE Since `$localize` is a global function, it must be included in any applications that use i18n. This is achieved by importing the `@angular/localize` package into an appropriate bundle, where it will be executed before the renderer needs to call `$localize`. For CLI based projects, this is best done in the `polyfills.ts` file. ```ts import '@angular/localize'; ``` For non-CLI applications this could be added as a script to the index.html file or another suitable script file. PR Close angular#31609

This has been replaced by the `$localize` tag. PR Close angular#31609

) This has been replaced by the `loadTranslations()` function in `@angular/localize/run_time`. PR Close angular#31609

PR Close angular#31609

This test uses localization in the `AppComponent` component: * an `i18n` attribute in the template * a call to the `$localize` tag in the component constructor PR Close angular#31609

…lar#31609) PR Close angular#31609

angular-automatic-lock-bot · 2019-10-04T16:06:41Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jul 17, 2019

petebacondarwin added the state: WIP label Jul 17, 2019

petebacondarwin force-pushed the i18n-localize-init branch 2 times, most recently from fa4213d to 84eff89 Compare July 17, 2019 16:07

mhevery approved these changes Jul 17, 2019

View reviewed changes

tsconfig.json Outdated Show resolved Hide resolved

packages/i18n/localize/src/hash.ts Outdated Show resolved Hide resolved

packages/i18n/localize/src/hash.ts Outdated Show resolved Hide resolved

mhevery added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 17, 2019

googlebot added cla: no and removed cla: yes labels Jul 17, 2019

matsko added the area: i18n Issues related to localization and internationalization label Jul 17, 2019

ngbot bot added this to the needsTriage milestone Jul 17, 2019

ocombe approved these changes Jul 18, 2019

View reviewed changes

petebacondarwin force-pushed the i18n-localize-init branch from dcc05e6 to 78021d4 Compare July 18, 2019 09:34

googlebot removed the cla: no label Jul 18, 2019

googlebot added cla: no and removed cla: yes labels Jul 18, 2019

petebacondarwin force-pushed the i18n-localize-init branch from 0afe5b9 to feec4a8 Compare July 18, 2019 20:24

googlebot added cla: yes and removed cla: no labels Jul 18, 2019

petebacondarwin marked this pull request as ready for review July 18, 2019 20:25

petebacondarwin requested review from IgorMinar and a team as code owners July 18, 2019 20:25

petebacondarwin force-pushed the i18n-localize-init branch 2 times, most recently from 0b49661 to 416d8b6 Compare July 18, 2019 21:06

petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews state: WIP labels Jul 18, 2019

mhevery closed this in b34bdf5 Aug 30, 2019

mhevery pushed a commit that referenced this pull request Aug 30, 2019

feat(ivy): implement $localize() global function (#31609)

b21397b

PR Close #31609

mhevery pushed a commit that referenced this pull request Aug 30, 2019

refactor(ivy): remove i18nLocalize instruction (#31609)

c024d89

This has been replaced by the `$localize` tag. PR Close #31609

mhevery pushed a commit that referenced this pull request Aug 30, 2019

refactor(ivy): remove i18nConfigureLocalize instruction (#31609)

a7f61e6

This has been replaced by the `loadTranslations()` function in `@angular/localize/run_time`. PR Close #31609

mhevery pushed a commit that referenced this pull request Aug 30, 2019

docs(core): update the i18n design doc (#31609)

fe5caca

PR Close #31609

mhevery pushed a commit that referenced this pull request Aug 30, 2019

test: make cli-hello-world-ivy-minimal/debug-test.sh executable (#31609)

9a55eaf

PR Close #31609

petebacondarwin deleted the i18n-localize-init branch August 30, 2019 20:19

petebacondarwin mentioned this pull request Sep 4, 2019

[IVY] i18n not working yet? #32311

Closed

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

test(common): remove redundant line from karma config (angular#31609)

c23d200

The files in the pattern do not exist. PR Close angular#31609

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

feat(ivy): implement $localize() global function (angular#31609)

6470f2a

PR Close angular#31609

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

refactor(ivy): remove i18nLocalize instruction (angular#31609)

f92ae0a

This has been replaced by the `$localize` tag. PR Close angular#31609

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

docs(core): update the i18n design doc (angular#31609)

9eac396

PR Close angular#31609

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

test: make cli-hello-world-ivy-minimal/debug-test.sh executable (angu…

939fc4a

…lar#31609) PR Close angular#31609

angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(i18n): initial `$localize` functionality #31609

feat(i18n): initial `$localize` functionality #31609

Uh oh!

petebacondarwin commented Jul 17, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

googlebot commented Jul 17, 2019

Uh oh!

googlebot commented Jul 18, 2019

Uh oh!

googlebot commented Jul 18, 2019

Uh oh!

googlebot commented Jul 18, 2019

Uh oh!

mhevery commented Aug 30, 2019

Uh oh!

mhevery commented Sep 3, 2019 •

edited

Loading

Uh oh!

angular-automatic-lock-bot bot commented Oct 4, 2019

Uh oh!

Uh oh!

feat(i18n): initial $localize functionality #31609

feat(i18n): initial $localize functionality #31609

Uh oh!

Conversation

petebacondarwin commented Jul 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

googlebot commented Jul 17, 2019

Uh oh!

googlebot commented Jul 18, 2019

Uh oh!

googlebot commented Jul 18, 2019

Uh oh!

googlebot commented Jul 18, 2019

Uh oh!

mhevery commented Aug 30, 2019

Uh oh!

mhevery commented Sep 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angular-automatic-lock-bot bot commented Oct 4, 2019

Uh oh!

Uh oh!

feat(i18n): initial `$localize` functionality #31609

feat(i18n): initial `$localize` functionality #31609

petebacondarwin commented Jul 17, 2019 •

edited

Loading

mhevery commented Sep 3, 2019 •

edited

Loading