fix(ngcc): add reexports only once #33658
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ngcc is configured to generate reexports for a package using the `generateDeepReexports` configuration option, it could incorrectly render the reexports as often as the number of compiled classes in the declaration file. This would cause compilation errors due to duplicated declarations.
JoostK
added
type: bug/fix
action: review
gkalpak
approved these changes
Nov 7, 2019
JoostK
added
action: merge
petebacondarwin
approved these changes
Nov 7, 2019
atscott
pushed a commit
that referenced
this pull request
Nov 7, 2019
When ngcc is configured to generate reexports for a package using the `generateDeepReexports` configuration option, it could incorrectly render the reexports as often as the number of compiled classes in the declaration file. This would cause compilation errors due to duplicated declarations. PR Close #33658
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ngcc is configured to generate reexports for a package using the
generateDeepReexportsconfiguration option, it could incorrectlyrender the reexports as often as the number of compiled classes in the
declaration file. This would cause compilation errors due to duplicated
declarations.