-
Notifications
You must be signed in to change notification settings - Fork 26.5k
fix(docs) Fixes typo in ProtoViewRef class #3677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed 'foctary' to 'factory'. I wanted to change `{@link AppViewManager#createViewInContainer}` to `{@link AppViewManager#createViewInContainer}#createViewInContainer` and `{@link AppViewManager#createRootHostView}` to `{@link AppViewManager#createRootHostView}#createRootHostView` for readibility (see https://angular.io/docs/js/latest/api/core/ProtoViewRef-class.html it shows `AppViewManager and AppViewManager`). But I'm not sure if that'll work so I'm just going with the typo.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
@ericmartinezr I'm happy you made it! LGTM! Regarding the link syntax, I think we should ask @petebacondarwin here :) |
@ericmartinezr I think what you're searching for is something like this:
|
@PascalPrecht That's exactly what I wanted. Should I create another PR? Or maybe a next time. |
@ericmartinezr yes, please send another PR with the link changes :) |
@PascalPrecht Done, please review it #3693 |
Merging PR #3677 on behalf of @mhevery to branch presubmit-mhevery-pr-3677. |
Follows #3677 I hope this works.
Follows #3677 I hope this works.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Changed 'foctary' to 'factory'.
I wanted to change
{@link AppViewManager#createViewInContainer}
to{@link AppViewManager#createViewInContainer}#createViewInContainer
{@link AppViewManager#createRootHostView}
to{@link AppViewManager#createRootHostView}#createRootHostView
for readibility (see https://angular.io/docs/js/latest/api/core/ProtoViewRef-class.html it shows
AppViewManager and AppViewManager
). But I'm not sure if that'll work so I'm just going with the typo.Reference to angular/angular.io#188
Please review, I'm quite new to this.