Skip to content

fix(docs) Fixes typo in ProtoViewRef class #3677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(docs) Fixes typo in ProtoViewRef class #3677

wants to merge 1 commit into from

Conversation

ericmartinezr
Copy link
Contributor

Changed 'foctary' to 'factory'.

I wanted to change

  • {@link AppViewManager#createViewInContainer} to {@link AppViewManager#createViewInContainer}#createViewInContainer
  • {@link AppViewManager#createRootHostView} to {@link AppViewManager#createRootHostView}#createRootHostView

for readibility (see https://angular.io/docs/js/latest/api/core/ProtoViewRef-class.html it shows AppViewManager and AppViewManager). But I'm not sure if that'll work so I'm just going with the typo.

Reference to angular/angular.io#188

Please review, I'm quite new to this.

Changed 'foctary' to 'factory'.

I wanted to change `{@link AppViewManager#createViewInContainer}` to `{@link AppViewManager#createViewInContainer}#createViewInContainer` and `{@link AppViewManager#createRootHostView}` to `{@link AppViewManager#createRootHostView}#createRootHostView` for readibility (see https://angular.io/docs/js/latest/api/core/ProtoViewRef-class.html it shows `AppViewManager and AppViewManager`). But I'm not sure if that'll work so I'm just going with the typo.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ericmartinezr
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@0x-r4bbit
Copy link
Contributor

@ericmartinezr I'm happy you made it! LGTM!

Regarding the link syntax, I think we should ask @petebacondarwin here :)

@0x-r4bbit
Copy link
Contributor

@ericmartinezr I think what you're searching for is something like this:

* The default is {@link ViewEncapsulation#EMULATED `ViewEncapsulation.EMULATED`} if the view

@ericmartinezr
Copy link
Contributor Author

@PascalPrecht That's exactly what I wanted. Should I create another PR? Or maybe a next time.

@0x-r4bbit
Copy link
Contributor

@ericmartinezr yes, please send another PR with the link changes :)

@ericmartinezr
Copy link
Contributor Author

@PascalPrecht Done, please review it #3693

@mhevery mhevery added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Aug 18, 2015
@mary-poppins
Copy link

Merging PR #3677 on behalf of @mhevery to branch presubmit-mhevery-pr-3677.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 18, 2015
mhevery pushed a commit that referenced this pull request Aug 18, 2015
Follows #3677

I hope this works.
@mhevery mhevery closed this in 63a94ee Aug 18, 2015
mhevery pushed a commit that referenced this pull request Aug 21, 2015
Follows #3677

I hope this works.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants