fix(service-worker): add `UNRECOVERABLE_STATE` handler #36847

sonukapoor · 2020-04-29T02:01:04Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: #36539

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

IgorMinar

I like where this is heading, but I suggest that we use terminology different from unrecovered because it gets awkward and confusing to use it. How about using defunkt, terminalError, or something of that sort?

gkalpak · 2020-06-16T14:41:39Z

@IgorMinar, I was the one that proposed "unrecoverable"/"unrecoverableState" (I assume "unrecovered" is a typo). I find "unrecoverable" more descriptive than "defunkt" or "terminalError" (but not a hill I'm going to die on 😁).

gkalpak

Thx, @sonukapoor! I've suggested some changes. LMK what you think.

Note to self: We need to document this in the appropriate guides (with code examples).

goldens/public-api/service-worker/service-worker.d.ts

packages/service-worker/src/low_level.ts

packages/service-worker/worker/src/assets.ts

packages/service-worker/src/update.ts

packages/service-worker/src/low_level.ts

sonukapoor · 2020-06-17T12:19:04Z

@gkalpak Please review again. I have made some of the suggested changes. I will address unit tests once we are OK with the changes.

mary-poppins · 2020-08-31T10:24:30Z

You can preview ab76f91 at https://pr36847-ab76f91.ngbuilds.io/.

AndrewKushnir

Reviewed-for: public-api

#36847) Previously, the condition to make the cache busted was executing although the network request was successful. However, this is not valid. The cache should only be marked as busted when the request failed. This commit fixes the invalid condition. PR Close #36847

In several occasions it has been observed when the browser has evicted eagerly cached assets from the cache and which can also not be found on the server anymore. This can lead to broken state where only parts of the application will load and others will fail. This commit fixes this issue by checking for the missing asset in the cache and on the server. If this condition is true, the broken client will be notified about the current state through the `UnrecoverableStateError`. Closes #36539 PR Close #36847

) PR Close #36847

…#36847) PR Close #36847

…gular#36847) This commit adds a helper method to remove individual cached items. PR Close angular#36847

angular#36847) Previously, the condition to make the cache busted was executing although the network request was successful. However, this is not valid. The cache should only be marked as busted when the request failed. This commit fixes the invalid condition. PR Close angular#36847

In several occasions it has been observed when the browser has evicted eagerly cached assets from the cache and which can also not be found on the server anymore. This can lead to broken state where only parts of the application will load and others will fail. This commit fixes this issue by checking for the missing asset in the cache and on the server. If this condition is true, the broken client will be notified about the current state through the `UnrecoverableStateError`. Closes angular#36539 PR Close angular#36847

…ular#36847) PR Close angular#36847

…angular#36847) PR Close angular#36847

govi2010 · 2020-09-14T10:07:46Z

How can I get this fix?
I am following this PR which is closed.
I am using PWA with angular 9.
How can I get this Fix ?

gkalpak · 2020-09-14T19:36:42Z

@govi2010, this feature was introduced in v11.0.0-next.0. The first stable version that will have it is 11.0.0.

angular-automatic-lock-bot · 2020-10-15T16:27:31Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Apr 29, 2020

sonukapoor force-pushed the service-worker-invalid-resource branch 2 times, most recently from 1d2fa37 to 6f833e7 Compare April 29, 2020 02:23

sonukapoor changed the title ~~Service worker invalid resource~~ fix(service-worker): add RESOURCE_REMOVED handler Apr 29, 2020

AndrewKushnir added the area: service-worker Issues related to the @angular/service-worker package label Apr 29, 2020

ngbot bot added this to the needsTriage milestone Apr 29, 2020

sonukapoor force-pushed the service-worker-invalid-resource branch 3 times, most recently from a9d8a4b to 9d1f214 Compare April 30, 2020 10:56

sonukapoor force-pushed the service-worker-invalid-resource branch 6 times, most recently from 0396e7a to fd1ab83 Compare May 15, 2020 20:34

sonukapoor changed the title ~~fix(service-worker): add RESOURCE_REMOVED handler~~ fix(service-worker): add UNRECOVERABLE_STATE handler May 15, 2020

sonukapoor force-pushed the service-worker-invalid-resource branch from fd1ab83 to 9843c4f Compare May 15, 2020 21:33

gkalpak mentioned this pull request May 26, 2020

Uncaught SyntaxError: Unexpected token '<' error after redirect to Angular PWA site after every new deployment #35077

Closed

IgorMinar requested review from IgorMinar and gkalpak June 3, 2020 21:01

IgorMinar reviewed Jun 4, 2020

View reviewed changes

gkalpak added state: WIP PR target: TBD feature Issue that requests a new feature labels Jun 14, 2020

gkalpak mentioned this pull request Jun 15, 2020

fix(service-worker): handle eagerly-cached assets unexpectedly missing from the cache #36539

Closed

gkalpak requested changes Jun 16, 2020

View reviewed changes

petebacondarwin assigned aikithoughts Jun 18, 2020

sonukapoor force-pushed the service-worker-invalid-resource branch from db24ed5 to 680010b Compare June 18, 2020 11:19

sonukapoor added 4 commits August 31, 2020 06:12

fixup! docs(service-worker): add section to explain unrecoverable state

0a9fe89

fixup! feat(service-worker): add UnrecoverableStateError

69029a2

docs(service-worker): add links to service worker communication guide

e08b6d5

fixup! feat(service-worker): add UnrecoverableStateError

ab76f91

sonukapoor force-pushed the service-worker-invalid-resource branch from 01a67a7 to ab76f91 Compare August 31, 2020 10:13

AndrewKushnir approved these changes Aug 31, 2020

View reviewed changes

sonukapoor removed request for alxhub, pkozlowski-opensource and jelbourn August 31, 2020 18:09

sonukapoor added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 31, 2020

gkalpak added target: minor This PR is targeted for the next minor release and removed target: major This PR is targeted for the next major release labels Aug 31, 2020

josephperrott closed this in 38d6596 Aug 31, 2020

josephperrott pushed a commit that referenced this pull request Aug 31, 2020

docs(service-worker): add section to explain unrecoverable state (#36847

f5d1e9a

) PR Close #36847

josephperrott pushed a commit that referenced this pull request Aug 31, 2020

docs(service-worker): add links to service worker communication guide (…

0fc2bef

…#36847) PR Close #36847

profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020

test(service-worker): add helper function remove individual cache (an…

71689e2

…gular#36847) This commit adds a helper method to remove individual cached items. PR Close angular#36847

profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020

docs(service-worker): add section to explain unrecoverable state (ang…

41ecb6f

…ular#36847) PR Close angular#36847

profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020

docs(service-worker): add links to service worker communication guide (…

f6c7492

…angular#36847) PR Close angular#36847

sonukapoor deleted the service-worker-invalid-resource branch September 14, 2020 10:14

gkalpak mentioned this pull request Oct 9, 2020

First load of docs site does not work if opened in a background tab #39153

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(service-worker): add `UNRECOVERABLE_STATE` handler #36847

fix(service-worker): add `UNRECOVERABLE_STATE` handler #36847

Uh oh!

sonukapoor commented Apr 29, 2020 •

edited

Loading

Uh oh!

IgorMinar left a comment

Uh oh!

gkalpak commented Jun 16, 2020

Uh oh!

gkalpak left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonukapoor commented Jun 17, 2020

Uh oh!

mary-poppins commented Aug 31, 2020

Uh oh!

AndrewKushnir left a comment

Uh oh!

govi2010 commented Sep 14, 2020

Uh oh!

gkalpak commented Sep 14, 2020

Uh oh!

angular-automatic-lock-bot bot commented Oct 15, 2020

Uh oh!

Uh oh!

fix(service-worker): add UNRECOVERABLE_STATE handler #36847

fix(service-worker): add UNRECOVERABLE_STATE handler #36847

Uh oh!

Conversation

sonukapoor commented Apr 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

gkalpak commented Jun 16, 2020

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonukapoor commented Jun 17, 2020

Uh oh!

mary-poppins commented Aug 31, 2020

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

govi2010 commented Sep 14, 2020

Uh oh!

gkalpak commented Sep 14, 2020

Uh oh!

angular-automatic-lock-bot bot commented Oct 15, 2020

Uh oh!

Uh oh!

fix(service-worker): add `UNRECOVERABLE_STATE` handler #36847

fix(service-worker): add `UNRECOVERABLE_STATE` handler #36847

sonukapoor commented Apr 29, 2020 •

edited

Loading