Skip to content

Remove deprecated support for IE 9, 10, and IE mobile #38931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AndrewKushnir
Copy link
Contributor

This PR contains a few commits to remove deprecated support for IE 9, 10, and IE mobile from docs and CI.
Additional code cleanup to remove the code specific to IE 9/10 will happen in followup PRs.

Does this PR introduce a breaking change?

  • Yes
  • No

Angular framework stops IE 9, 10, and IE mobile support.

In v10, framework support for IE 9, 10, and IE mobile was deprecated. In v11 we remove support
for these browsers.

This commit updates angular.io docs to exclude references to IE 9, 10, and IE mobile as well as
polyfills that were needed to run Angular-based apps in these browsers.
This commit removes IE 9 and IE 10 from the browser configuration that is used by CI, so tests
would no longer be executed in these browsers.
This commit removes polyfills that were needed to run tests on IE 9 and IE 10.

BREAKING CHANGE:

In v10, IE 9, 10, and IE mobile support was deprecated. In v11, Angular framework removes IE 9,
10, and IE mobile support completely.
Supporting outdated browsers like these increases bundle size, code complexity, and test load,
and also requires time and effort that could be spent on improvements to the framework.
For example, fixing issues can be more difficult, as a straightforward fix for modern browsers
could break old ones that have quirks due to not receiving updates from vendors.
@AndrewKushnir AndrewKushnir added state: WIP comp: docs area: build & ci Related the build and CI infrastructure of the project breaking changes target: major This PR is targeted for the next major release labels Sep 21, 2020
@ngbot ngbot bot modified the milestone: needsTriage Sep 21, 2020
@mary-poppins
Copy link

You can preview 17428a0 at https://pr38931-17428a0.ngbuilds.io/.

@AndrewKushnir AndrewKushnir marked this pull request as ready for review September 22, 2020 01:27
@pullapprove pullapprove bot requested review from gkalpak and jelbourn September 22, 2020 01:27
@AndrewKushnir AndrewKushnir requested review from IgorMinar and removed request for gkalpak September 22, 2020 01:27
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Sep 22, 2020
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
// cc @StephenFluin

Copy link
Contributor

@aikithoughts aikithoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: required-docs-approvers

@aikithoughts aikithoughts added effort1: hours risk: medium feature Issue that requests a new feature labels Sep 22, 2020
@ngbot ngbot bot removed this from the needsTriage milestone Sep 22, 2020
@ngbot ngbot bot modified the milestones: Backlog, needsTriage Sep 22, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: docs-packaging-and-releasing

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: docs-packaging-and-releasing

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 24, 2020
@alxhub alxhub closed this in 9aff09b Sep 25, 2020
alxhub pushed a commit that referenced this pull request Sep 25, 2020
This commit removes IE 9 and IE 10 from the browser configuration that is used by CI, so tests
would no longer be executed in these browsers.

PR Close #38931
alxhub pushed a commit that referenced this pull request Sep 25, 2020
…#38931)

This commit removes polyfills that were needed to run tests on IE 9 and IE 10.

BREAKING CHANGE:

In v10, IE 9, 10, and IE mobile support was deprecated. In v11, Angular framework removes IE 9,
10, and IE mobile support completely.
Supporting outdated browsers like these increases bundle size, code complexity, and test load,
and also requires time and effort that could be spent on improvements to the framework.
For example, fixing issues can be more difficult, as a straightforward fix for modern browsers
could break old ones that have quirks due to not receiving updates from vendors.

PR Close #38931
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project breaking changes cla: yes effort1: hours feature Issue that requests a new feature risk: medium target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants