feat(language-service): add quick info for inline templates in ivy #39060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
action: review
atscott
force-pushed
the
keenpairing
branch
2 times, most recently
from
2aa4b3a to
4c5ee5e
Compare
josephperrott
approved these changes
Sep 30, 2020
atscott
force-pushed
the
keenpairing
branch
2 times, most recently
from
98122c1 to
85480f7
Compare
ayazhafiz
reviewed
Sep 30, 2020
kyliau
suggested changes
Sep 30, 2020
ayazhafiz
reviewed
Oct 1, 2020
atscott
force-pushed
the
keenpairing
branch
3 times, most recently
from
a0f4333 to
e5a730c
Compare
ayazhafiz
reviewed
Oct 1, 2020
Comment on lines
199
to
203
| /** | ||
| * Returns a new `ts.SymbolDisplayPart` array which has the alias imports from the tcb filtered | ||
| * out, i.e. `i0.NgForOf`. | ||
| */ | ||
| export function filterAliasImports(displayParts: ts.SymbolDisplayPart[]) { |
There was a problem hiding this comment.
I almost feel like this should be a util provided by the compiler. But I guess the language service relies on the TCB leaking, so I am ambivalent either way. Just thought I would comment.
atscott
force-pushed
the
keenpairing
branch
3 times, most recently
from
4dc345b to
06713f3
Compare
kyliau
approved these changes
Oct 2, 2020
Adds implementation for `getQuickInfoAtPosition` to the Ivy Language Service, which now returns `ts.QuickInfo` for inline templates.
atscott
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation for
getQuickInfoAtPositionto the Ivy LanguageService, which now returns
ts.QuickInfofor inline templates.