-
Notifications
You must be signed in to change notification settings - Fork 26.6k
feat(language-service): Add diagnostics to suggest turning on strictTemplates #40423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9696074
to
4ffd0c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f76888e
to
658b730
Compare
658b730
to
a3ca10b
Compare
1d52c8e
to
c6d8eac
Compare
c6d8eac
to
eb1fae9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
eb1fae9
to
207f43e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I did some bike-shedding on the exact copy of the diagnostic, but that's not a blocker for me :).
207f43e
to
ec0d416
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
3e70028
to
1db787e
Compare
…mode This PR adds a way for the language server to retrieve compiler options diagnostics via `languageService.getCompilerOptionsDiagnostics()`. This will be used by the language server to show a prompt in the editor if users don't have `strict` or `fullTemplateTypeCheck` turned on. Ref angular/vscode-ng-language-service#1053
1db787e
to
2f0eff5
Compare
@kyliau This PR has conflicts with the |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR creates a way for the language server to retrieve compiler options
diagnostics via
languageService.getCompilerOptionsDiagnostics()
.This will be used by the language server to show a prompt in the editor if
users don't have
strictTemplates
orfullTemplateTypeCheck
turned on.Ref angular/vscode-ng-language-service#1053
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information