Skip to content

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Jan 14, 2021

This PR creates a way for the language server to retrieve compiler options
diagnostics via languageService.getCompilerOptionsDiagnostics().

This will be used by the language server to show a prompt in the editor if
users don't have strictTemplates or fullTemplateTypeCheck turned on.

Ref angular/vscode-ng-language-service#1053

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Jan 14, 2021
@kyliau kyliau requested a review from atscott January 14, 2021 01:08
@pullapprove pullapprove bot requested review from alxhub and josephperrott January 14, 2021 01:08
@kyliau kyliau requested review from zarend and removed request for josephperrott January 14, 2021 01:08
@kyliau kyliau added the target: minor This PR is targeted for the next minor release label Jan 14, 2021
@pullapprove pullapprove bot requested a review from josephperrott January 14, 2021 01:09
@kyliau kyliau added the area: language-service Issues related to Angular's VS Code language service label Jan 14, 2021
@ngbot ngbot bot added this to the Backlog milestone Jan 14, 2021
@kyliau kyliau added the area: compiler Issues related to `ngc`, Angular's template compiler label Jan 14, 2021
@kyliau kyliau force-pushed the suggest-strict-mode branch 3 times, most recently from 9696074 to 4ffd0c5 Compare January 14, 2021 17:13
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyliau kyliau force-pushed the suggest-strict-mode branch from f76888e to 658b730 Compare January 14, 2021 22:05
@kyliau kyliau force-pushed the suggest-strict-mode branch from 658b730 to a3ca10b Compare January 20, 2021 22:46
@kyliau kyliau requested a review from alxhub January 20, 2021 22:47
@kyliau kyliau force-pushed the suggest-strict-mode branch 2 times, most recently from 1d52c8e to c6d8eac Compare January 21, 2021 22:13
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from jelbourn January 21, 2021 22:24
@kyliau kyliau force-pushed the suggest-strict-mode branch from eb1fae9 to 207f43e Compare January 21, 2021 22:29
@kyliau kyliau changed the title feat(language-service): Add diagnostics to suggest turning on strict mode feat(language-service): Add diagnostics to suggest turning on strictTemplates Jan 21, 2021
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from alxhub January 21, 2021 23:10
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I did some bike-shedding on the exact copy of the diagnostic, but that's not a blocker for me :).

@kyliau kyliau force-pushed the suggest-strict-mode branch from 207f43e to ec0d416 Compare January 21, 2021 23:24
@kyliau kyliau added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Jan 22, 2021
@kyliau
Copy link
Contributor Author

kyliau commented Jan 22, 2021

@pullapprove pullapprove bot requested a review from petebacondarwin January 22, 2021 17:45
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Jan 22, 2021
…mode

This PR adds a way for the language server to retrieve compiler options
diagnostics via `languageService.getCompilerOptionsDiagnostics()`.

This will be used by the language server to show a prompt in the editor if
users don't have `strict` or `fullTemplateTypeCheck` turned on.

Ref angular/vscode-ng-language-service#1053
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 22, 2021
@jessicajaniuk
Copy link
Contributor

@kyliau This PR has conflicts with the 11.1.x branch. it's been retargeted to minor and merged into master only. Could you create a patch-only version of this PR to get it into 11.1.x?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: language-service Issues related to Angular's VS Code language service cla: yes target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants