Skip to content

docs: update contributors.json #41284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

docs: update contributors.json #41284

wants to merge 1 commit into from

Conversation

cindygk
Copy link
Contributor

@cindygk cindygk commented Mar 19, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Mar 19, 2021
@pullapprove pullapprove bot requested a review from mgechev March 19, 2021 19:32
@cindygk
Copy link
Contributor Author

cindygk commented Mar 19, 2021

Updating contributors file to remove Jules, Manu and Stephen (and updating cindygk's twitter name)

@AndrewKushnir
Copy link
Contributor

Hi @cindygk, thanks for updating the contributors.json file. There are some failures in tests that verify that the "lead" field points to an existing entry in that file (which is now a problem since you've removed juleskremer, see here for example). Could you please update the file to remove these lines too?

Could you please also update the commit message to add docs: to the very beginning? So the commit message may look like this:

docs: update contributors.json

Thank you.

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release comp: docs labels Mar 19, 2021
@ngbot ngbot bot added this to the Backlog milestone Mar 19, 2021
@AndrewKushnir AndrewKushnir changed the title Update contributors.json docs: update contributors.json Mar 19, 2021
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 19, 2021
@AndrewKushnir
Copy link
Contributor

@cindygk FYI I've added the necessary changes, the PR should be fully ready for review now.
@mgechev could you please have a look when you get a chance?

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 20, 2021
@mhevery mhevery closed this in efe02d8 Mar 22, 2021
mhevery pushed a commit that referenced this pull request Mar 22, 2021
TeriGlover pushed a commit to TeriGlover/angular that referenced this pull request Apr 5, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 22, 2021
@josephperrott josephperrott deleted the cindygk-patch-2 branch January 18, 2024 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants