fix(router): unset attachRef when router-outlet is destroyed to avoid mounting a destroyed component #43697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mounting a destroyed component Previously, when a router-outlet is conditionally shown with an ngIf, and a sub-route was re-attached via a custom RouteReuseStrategy, router-outlet would try to mount a destroyed component into the view if the router-outlet is destroyed and re-initialized. This commit fixes it by unsetting context.attachRef when router-outlet is destroyed, so when the router-outlet is being initialized again, it no longer sees an attachRef that it needs to mount to the view. Fixes angular#43696
atscott
approved these changes
Oct 4, 2021
…o avoid mounting a destroyed component
…o avoid mounting a destroyed component
|
@atscott Thanks for the approval! I fixed the dumb test failure and code formatting, hopefully I've followed the conventions well :) |
atscott
added
action: merge
|
This PR was merged into the repository by commit 2ab2a08. |
dylhunn
pushed a commit
that referenced
this pull request
Oct 5, 2021
… mounting a destroyed component (#43697) Previously, when a router-outlet is conditionally shown with an ngIf, and a sub-route was re-attached via a custom RouteReuseStrategy, router-outlet would try to mount a destroyed component into the view if the router-outlet is destroyed and re-initialized. This commit fixes it by unsetting context.attachRef when router-outlet is destroyed, so when the router-outlet is being initialized again, it no longer sees an attachRef that it needs to mount to the view. Fixes #43696 PR Close #43697
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Serginho
pushed a commit
to TuLotero/angular
that referenced
this pull request
Jan 20, 2022
… mounting a destroyed component (angular#43697) Previously, when a router-outlet is conditionally shown with an ngIf, and a sub-route was re-attached via a custom RouteReuseStrategy, router-outlet would try to mount a destroyed component into the view if the router-outlet is destroyed and re-initialized. This commit fixes it by unsetting context.attachRef when router-outlet is destroyed, so when the router-outlet is being initialized again, it no longer sees an attachRef that it needs to mount to the view. Fixes angular#43696 PR Close angular#43697
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a
router-outletis conditionally shown with anngIf, and a sub-route was re-attachedvia a custom
RouteReuseStrategy,router-outletwould try to mount a destroyed component into the viewif the
router-outletis destroyed and re-initialized.This commit fixes it by unsetting
context.attachRefwhenrouter-outletis destroyed, so when therouter-outletis being initialized again, it no longer sees anattachRefthat it needs to mount to theview.
Fixes #43696
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #43696
What is the new behavior?
Router-outlet re-creates the component for child route if it is previously destroyed.
Does this PR introduce a breaking change?
Other information