refactor(compiler): remove parsing support for quote expressions #44915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
added
target: major
So-called "Quote expressions" were added in b6ec238 to support foreign syntax to be used in Angular templates, requiring a custom template transform to convert them somehow during compilation. Support for template transforms was originally implemented in a43ed79 but has since been dropped. Since the compiler is not public API the quote expressions should not have any usages anymore. Removing support for them can improve error reporting for expressions that contain a `:`, e.g. binding to a URL without quotes: ```html <a [href]="http://google.com">Click me</a> ``` Here, `http` would be parsed as foreign "http" quote expression with `//google.com` as value, later reporting the error "Quotes are not supported for evaluation!" because there was no template transform to convert that code. Closes angular#40398
JoostK
force-pushed
the
remove-template-quote
branch
from
768db48 to
1bde6af
Compare
|
I wouldn't classify this as breaking change that needs a deprecation, as I believe this is just dead code at this point in time. |
atscott
approved these changes
Jan 31, 2022
|
This PR was merged into the repository by commit db05ae1. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
josmar-crwdstffng
pushed a commit
to josmar-crwdstffng/angular
that referenced
this pull request
Apr 8, 2022
…ular#44915) So-called "Quote expressions" were added in b6ec238 to support foreign syntax to be used in Angular templates, requiring a custom template transform to convert them somehow during compilation. Support for template transforms was originally implemented in a43ed79 but has since been dropped. Since the compiler is not public API the quote expressions should not have any usages anymore. Removing support for them can improve error reporting for expressions that contain a `:`, e.g. binding to a URL without quotes: ```html <a [href]="http://google.com">Click me</a> ``` Here, `http` would be parsed as foreign "http" quote expression with `//google.com` as value, later reporting the error "Quotes are not supported for evaluation!" because there was no template transform to convert that code. Closes angular#40398 PR Close angular#44915
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So-called "Quote expressions" were added in b6ec238
to support foreign syntax to be used in Angular templates, requiring a custom
template transform to convert them somehow during compilation. Support for template
transforms was originally implemented in a43ed79 but
has since been dropped. Since the compiler is not public API the quote expressions
should not have any usages anymore. Removing support for them can improve error
reporting for expressions that contain a
:, e.g. binding to a URL without quotes:Here,
httpwould be parsed as foreign "http" quote expression with//google.comasvalue, later reporting the error "Quotes are not supported for evaluation!" because
there was no template transform to convert that code.
Closes #40398