Skip to content

Conversation

dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Feb 1, 2022

Previously, FormArray accepted an array generic. With the most up-to-date prototype, it accepts the element type, so the migration must be updated accordingly.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

…ead of FormArray<T[]>.

Previously, `FormArray` accepted an array generic. Now it accepts the element type, so the migration must be update accordingly.
@dylhunn dylhunn requested a review from AndrewKushnir February 1, 2022 21:30
@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer area: forms target: patch This PR is targeted for the next patch release labels Feb 1, 2022
@ngbot ngbot bot modified the milestone: Backlog Feb 1, 2022
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 1, 2022
@dylhunn dylhunn added the action: merge The PR is ready for merge by the caretaker label Feb 2, 2022
@jessicajaniuk
Copy link
Contributor

This has merge conflicts with 13.2.x. Updating to target: minor and merging. Please create a patch PR.

@jessicajaniuk jessicajaniuk added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 2, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit cae1e44.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 5, 2022
josmar-crwdstffng pushed a commit to josmar-crwdstffng/angular that referenced this pull request Apr 8, 2022
…ead of FormArray<T[]>. (angular#44933)

Previously, `FormArray` accepted an array generic. Now it accepts the element type, so the migration must be update accordingly.

PR Close angular#44933
@dylhunn dylhunn deleted the migration-fa branch November 30, 2022 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: forms forms: strictly typed target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants