fix(core): avoid Closure Compiler error in restoreView #45445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
approved these changes
Mar 25, 2022
Closure Compiler in advanced optimization mode may end up inlining the `ɵɵrestoreView` into the event listener which can lead to a runtime null pointer exception after the changes in angular#43075. These changes add an annotation to prevent function inlining of the specific instruction.
alxhub
approved these changes
Mar 25, 2022
crisbeto
force-pushed
the
restore-view-inlining
branch
from
19b6015 to
93f7f43
Compare
|
Pushed an extra change with a TODO for myself. |
crisbeto
added
area: core
crisbeto
added
action: merge
|
Presubmit running: http://test/OCL:437362873:BASE:437362993:1648252143897:abd5ce02 |
|
Presubmit looks good, except for one flake. |
|
This PR was merged into the repository by commit d36fa11. |
josmar-crwdstffng
pushed a commit
to josmar-crwdstffng/angular
that referenced
this pull request
Apr 8, 2022
Closure Compiler in advanced optimization mode may end up inlining the `ɵɵrestoreView` into the event listener which can lead to a runtime null pointer exception after the changes in angular#43075. These changes add an annotation to prevent function inlining of the specific instruction. PR Close angular#45445
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closure Compiler in advanced optimization mode may end up inlining the
ɵɵrestoreViewinto the event listener which can lead to a runtime null pointer exception after the changes in #43075.These changes add an annotation to prevent function inlining of the specific instruction.