refactor(localize): bundle message digest algorithm directly in npm package #48799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
added
the
area: i18n
dgp1130
approved these changes
Jan 20, 2023
hexiaokang
approved these changes
Jan 21, 2023
clydin
added
the
merge: squash commits
…ackage The main entry point for the `@angular/localize` package no longer imports the `@angular/compiler` package and now has no external dependencies. This allows the main functionality of the package to be used without requiring any other Angular packages. Only the message digest algorithm implementation from the `@angular/compiler` package was being used and this code is now bundled directly into the final npm package for `@angular/localize`. The `tooling` secondary entry point still leverages and requires Angular related packages (`@angular/compiler`/`@angular/compiler-cli`). However, the tooling functionality is not intended to be used and/or bundled in a web application. Closes angular#48163
clydin
force-pushed
the
i18n/localize-bundle-digest
branch
from
3015257 to
7ca5bd5
Compare
clydin
force-pushed
the
i18n/localize-bundle-digest
branch
from
1102f10 to
ce528cf
Compare
clydin
added
the
action: review
AndrewKushnir
approved these changes
Jan 24, 2023
AndrewKushnir
approved these changes
Jan 24, 2023
clydin
removed
the
action: review
|
This PR was merged into the repository by commit 402fcc5. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Jan 24, 2023
…ackage (#48799) The main entry point for the `@angular/localize` package no longer imports the `@angular/compiler` package and now has no external dependencies. This allows the main functionality of the package to be used without requiring any other Angular packages. Only the message digest algorithm implementation from the `@angular/compiler` package was being used and this code is now bundled directly into the final npm package for `@angular/localize`. The `tooling` secondary entry point still leverages and requires Angular related packages (`@angular/compiler`/`@angular/compiler-cli`). However, the tooling functionality is not intended to be used and/or bundled in a web application. Closes #48163 PR Close #48799
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…ackage (angular#48799) The main entry point for the `@angular/localize` package no longer imports the `@angular/compiler` package and now has no external dependencies. This allows the main functionality of the package to be used without requiring any other Angular packages. Only the message digest algorithm implementation from the `@angular/compiler` package was being used and this code is now bundled directly into the final npm package for `@angular/localize`. The `tooling` secondary entry point still leverages and requires Angular related packages (`@angular/compiler`/`@angular/compiler-cli`). However, the tooling functionality is not intended to be used and/or bundled in a web application. Closes angular#48163 PR Close angular#48799
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #48163
What is the new behavior?
The main entry point for the
@angular/localizepackage no longer imports the@angular/compilerpackage and now has no external dependencies. This allows the main functionality of the package to be used without requiring any other Angular packages. Only the message digest algorithm implementation from the@angular/compilerpackage was being used and this code is now bundled directly into the final npm package for@angular/localize.The
toolingsecondary entry point still leverages and requires Angular related packages (@angular/compiler/@angular/compiler-cli). However, the tooling functionality is not intended to be used and/or bundled in a web application.Does this PR introduce a breaking change?
Other information