refactor(core): remove DeepReadonly type wrapper for signals #49644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
area: core
pkozlowski-opensource
force-pushed
the
reactivity_signals_readonly_axe
branch
from
6cc6da5
to
1a6ce1e
Compare
We've been experimenting with the DeepReadonly type that would make signal values deeply read-only and prevent accidental changes without going to the owner of data. What we've found out during the experiments is that additional safety net has more drawbacks than benefits: it just introduces too much friction to be practical for daily usage.
pkozlowski-opensource
force-pushed
the
reactivity_signals_readonly_axe
branch
from
1a6ce1e
to
8332757
Compare
pkozlowski-opensource
added
the
action: review
alxhub
approved these changes
Mar 30, 2023
alxhub
approved these changes
Mar 30, 2023
|
Closing this PR as the commit from it got folded into #49154 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been experimenting with the DeepReadonly type that would make signal values deeply read-only and prevent accidental changes without going to the owner of data. What we've found out during the experiments is that additional safety net has more drawbacks than benefits: it just introduces too much friction to be practical for daily usage.