refactor(core): add asReadonly helper to writable signals #49802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
action: review
atscott
approved these changes
Apr 13, 2023
alxhub
reviewed
Apr 13, 2023
| const readOnlyCounter = counter.asReadonly(); | ||
|
|
||
| // @ts-expect-error | ||
| expect(readOnlyCounter.set).toBeUndefined(); |
There was a problem hiding this comment.
ts-expect-error is clever here - we both assert that the type is right and that the value doesn't contain the method. 👍
jessicajaniuk
approved these changes
Apr 13, 2023
alxhub
approved these changes
Apr 13, 2023
| @@ -137,6 +153,7 @@ export function signal<T>(initialValue: T, options?: CreateSignalOptions<T>): Wr | |||
| set: signalNode.set.bind(signalNode), | |||
| update: signalNode.update.bind(signalNode), | |||
| mutate: signalNode.mutate.bind(signalNode), | |||
| asReadonly: signalNode.asReadonly.bind(signalNode) | |||
There was a problem hiding this comment.
Is it worth the code size to memoize things here? We could instead do:
Suggested change
| asReadonly: signalNode.asReadonly.bind(signalNode) | |
| asReadonly: () => createSignalFromFunction(signalNode, signalNode.signal.bind(signalNode)), |
There was a problem hiding this comment.
Not sure! I could go either way. LMK if you've got a strong preference
pkozlowski-opensource
added
action: merge
The new asReadonly method on the WritableSignal interface makes it possible to create readonly instance of a writable signal. Readonly signals can be accessed to read their value, but can't be changed using set, update or mutate methods.
pkozlowski-opensource
force-pushed
the
signals_as_readonly
branch
from
eab0a2b to
745e9a1
Compare
pkozlowski-opensource
changed the title
|
This PR was merged into the repository by commit 2d0fcd6. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Apr 13, 2023
The new asReadonly method on the WritableSignal interface makes it possible to create readonly instance of a writable signal. Readonly signals can be accessed to read their value, but can't be changed using set, update or mutate methods. PR Close #49802
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new asReadonly method on the WritableSignal interface makes it possible to create readonly instance of a writable signal.
Readonly signals can be accessed to read their value, but can't be changed using set, update or mutate methods.