fix(router): Remove deprecated Router properties #51502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
detected: breaking change
|
Nit: You could also update the deprecation guide in this PR also. |
This commit removes deprecated properties on the Router. These are meant to be configured through DI and not meant to be changed during runtime. BREAKING CHANGE: The following Router properties have been removed from the public API: - canceledNavigationResolution - paramsInheritanceStrategy - titleStrategy - urlUpdateStrategy - malformedUriErrorHandler These should instead be configured through the `provideRouter` or `RouterModule.forRoot` APIs.
atscott
force-pushed
the
removedeprecations
branch
from
5cfbfb0 to
601fc14
Compare
pkozlowski-opensource
approved these changes
Aug 25, 2023
AndrewKushnir
approved these changes
Aug 26, 2023
|
This PR was merged into the repository by commit c62e680. |
LayZeeDK
pushed a commit
to LayZeeDK/angular__angular
that referenced
this pull request
Sep 20, 2023
This commit removes deprecated properties on the Router. These are meant to be configured through DI and not meant to be changed during runtime. BREAKING CHANGE: The following Router properties have been removed from the public API: - canceledNavigationResolution - paramsInheritanceStrategy - titleStrategy - urlUpdateStrategy - malformedUriErrorHandler These should instead be configured through the `provideRouter` or `RouterModule.forRoot` APIs. PR Close angular#51502
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This commit removes deprecated properties on the Router. These are meant to be configured through DI and not meant to be changed during runtime. BREAKING CHANGE: The following Router properties have been removed from the public API: - canceledNavigationResolution - paramsInheritanceStrategy - titleStrategy - urlUpdateStrategy - malformedUriErrorHandler These should instead be configured through the `provideRouter` or `RouterModule.forRoot` APIs. PR Close angular#51502
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes deprecated properties on the Router. These are meant to be configured through DI and not meant to be changed during runtime.
BREAKING CHANGE: The following Router properties have been removed from the public API:
These should instead be configured through the
provideRouterorRouterModule.forRootAPIs.