feat(platform-browser): enable removal of styles on component destroy by default #51571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
area: core
alan-agius4
force-pushed
the
change-remove-style-comp-destroy
branch
from
91bca8b to
67ece0a
Compare
angular-robot
bot
added
detected: breaking change
|
Caretaker note: this needed to be landed in combination with http://cl/561303540 as a patch need to be deleted. |
alan-agius4
added
the
merge: caretaker note
… by default
This change aligns the settings between G3 and P3 as `REMOVE_STYLES_ON_COMPONENT_DESTROY_DEFAULT` is already set to `true` internally.
BREAKING CHANGE: `REMOVE_STYLES_ON_COMPONENT_DESTROY` default value is now `true`. This causes CSS of components to be removed from the DOM when destroyed. You retain the previous behaviour by providing the `REMOVE_STYLES_ON_COMPONENT_DESTROY` injection token.
```ts
import {REMOVE_STYLES_ON_COMPONENT_DESTROY} from '@angular/platform-browser';
...
providers: [{
provide: REMOVE_STYLES_ON_COMPONENT_DESTROY,
useValue: false,
}]
```
alan-agius4
force-pushed
the
change-remove-style-comp-destroy
branch
from
67ece0a to
a70e23b
Compare
alan-agius4
added
the
action: review
jessicajaniuk
added
action: merge
|
This PR was merged into the repository by commit c340d6e. |
LayZeeDK
pushed a commit
to LayZeeDK/angular__angular
that referenced
this pull request
Sep 20, 2023
… by default (angular#51571) This change aligns the settings between G3 and P3 as `REMOVE_STYLES_ON_COMPONENT_DESTROY_DEFAULT` is already set to `true` internally. BREAKING CHANGE: `REMOVE_STYLES_ON_COMPONENT_DESTROY` default value is now `true`. This causes CSS of components to be removed from the DOM when destroyed. You retain the previous behaviour by providing the `REMOVE_STYLES_ON_COMPONENT_DESTROY` injection token. ```ts import {REMOVE_STYLES_ON_COMPONENT_DESTROY} from '@angular/platform-browser'; ... providers: [{ provide: REMOVE_STYLES_ON_COMPONENT_DESTROY, useValue: false, }] ``` PR Close angular#51571
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
… by default (angular#51571) This change aligns the settings between G3 and P3 as `REMOVE_STYLES_ON_COMPONENT_DESTROY_DEFAULT` is already set to `true` internally. BREAKING CHANGE: `REMOVE_STYLES_ON_COMPONENT_DESTROY` default value is now `true`. This causes CSS of components to be removed from the DOM when destroyed. You retain the previous behaviour by providing the `REMOVE_STYLES_ON_COMPONENT_DESTROY` injection token. ```ts import {REMOVE_STYLES_ON_COMPONENT_DESTROY} from '@angular/platform-browser'; ... providers: [{ provide: REMOVE_STYLES_ON_COMPONENT_DESTROY, useValue: false, }] ``` PR Close angular#51571
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns the settings between G3 and P3 as
REMOVE_STYLES_ON_COMPONENT_DESTROY_DEFAULTis already set totrueinternally.BREAKING CHANGE:
REMOVE_STYLES_ON_COMPONENT_DESTROYdefault value is nowtrue. This causes CSS of components to be removed from the DOM when destroyed. You retain the previous behaviour by providing theREMOVE_STYLES_ON_COMPONENT_DESTROYinjection token.