Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localize): ng-add schematics for application builder #51777

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The schematics did not support the application builder, which is the new default builder in an application built with the CLI v17

What is the new behavior?

The schematic now supports it.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR needs @shematics/angular v17, which will be the case once #51220 is merged

Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir AndrewKushnir added area: i18n target: major This PR is targeted for the next major release labels Sep 14, 2023
@ngbot ngbot bot modified the milestone: Backlog Sep 14, 2023
The schematics now supports the `application` builder, which is the new default builder in an application built with the CLI v17
@cexbrayat cexbrayat force-pushed the fix/localize-schematics-with-application-builder branch from 647720a to afd1e15 Compare September 14, 2023 17:37
@cexbrayat
Copy link
Member Author

PR rebased now that @josephperrott merged #51780

@AndrewKushnir AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Sep 14, 2023
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 5a20a44.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 16, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
The schematics now supports the `application` builder, which is the new default builder in an application built with the CLI v17

PR Close angular#51777
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: i18n target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants