New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(platform-browser): disable styles of removed components instead of removing #51808
perf(platform-browser): disable styles of removed components instead of removing #51808
Conversation
feb20b5
to
339cf0b
Compare
e3d9560
to
f40b24a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alan-agius4 thanks for the improvement 👍
5e9fe7f
to
cc84960
Compare
…of removing This commit changes the behaviour of `REMOVE_STYLES_ON_COMPONENT_DESTROY`. Now, `style` nodes are disabled instead of removed from DOM. This causes the same runtime behaviour but avoids recomputations when the stylesheet is re-added when the component is re-created. https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/css_style_sheet.h;l=266;drc=31fb07c05718d671d96c227855bfe97af9e3fb20 NB: This changes is being done following some performance bottlenecks observed in Phanteon and their own recommendations. Context: http://chat/room/AAAAxKxTk40/jaP6Lj6fhmQ/jaP6Lj6fhmQ https://crbug.com/1444522 http://b/289992821
…nstead of removing
cc84960
to
b944f4f
Compare
@AndrewKushnir, as mentioned offline, I had to re-add CSS removal/disabling for components that use view encapsulation. This is because a number of components in G3 use |
NOTE: TGP is green after deflaking. |
This PR was merged into the repository by commit 3c0577f. |
…of removing (angular#51808) This commit changes the behaviour of `REMOVE_STYLES_ON_COMPONENT_DESTROY`. Now, `style` nodes are disabled instead of removed from DOM. This causes the same runtime behaviour but avoids recomputations when the stylesheet is re-added when the component is re-created. https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/css_style_sheet.h;l=266;drc=31fb07c05718d671d96c227855bfe97af9e3fb20 NB: This changes is being done following some performance bottlenecks observed in Phanteon and their own recommendations. Context: http://chat/room/AAAAxKxTk40/jaP6Lj6fhmQ/jaP6Lj6fhmQ https://crbug.com/1444522 http://b/289992821 PR Close angular#51808
…instead of removing (angular#51808)" This reverts commit 3c0577f.
…instead of removing (angular#51808)" This reverts commit 65786b2 due to an oberved perf regression in Pantheon. See: http://b/303667704
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…of removing (angular#51808) This commit changes the behaviour of `REMOVE_STYLES_ON_COMPONENT_DESTROY`. Now, `style` nodes are disabled instead of removed from DOM. This causes the same runtime behaviour but avoids recomputations when the stylesheet is re-added when the component is re-created. https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/css_style_sheet.h;l=266;drc=31fb07c05718d671d96c227855bfe97af9e3fb20 NB: This changes is being done following some performance bottlenecks observed in Phanteon and their own recommendations. Context: http://chat/room/AAAAxKxTk40/jaP6Lj6fhmQ/jaP6Lj6fhmQ https://crbug.com/1444522 http://b/289992821 PR Close angular#51808
This commit changes the behaviour of
REMOVE_STYLES_ON_COMPONENT_DESTROY
.Now,
style
nodes are disabled instead of removed from DOM. This causes the same runtime behaviour but avoids recomputations when the stylesheet is re-added when the component is re-created. https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/css_style_sheet.h;l=266;drc=31fb07c05718d671d96c227855bfe97af9e3fb20NB: This changes is being done following some performance bottlenecks observed in Phanteon and their own recommendations.
Context:
http://chat/room/AAAAxKxTk40/jaP6Lj6fhmQ/jaP6Lj6fhmQ
https://crbug.com/1444522
http://b/289992821