perf(platform-browser): disable styles of removed components instead of removing #51808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
perf-dom-renderer-remove-css
branch
from
feb20b5 to
339cf0b
Compare
alan-agius4
added
area: core
alan-agius4
added
target: patch
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
perf-dom-renderer-remove-css
branch
6 times, most recently
from
e3d9560 to
f40b24a
Compare
AndrewKushnir
approved these changes
Sep 19, 2023
alan-agius4
force-pushed
the
perf-dom-renderer-remove-css
branch
3 times, most recently
from
5e9fe7f to
cc84960
Compare
…of removing This commit changes the behaviour of `REMOVE_STYLES_ON_COMPONENT_DESTROY`. Now, `style` nodes are disabled instead of removed from DOM. This causes the same runtime behaviour but avoids recomputations when the stylesheet is re-added when the component is re-created. https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/css_style_sheet.h;l=266;drc=31fb07c05718d671d96c227855bfe97af9e3fb20 NB: This changes is being done following some performance bottlenecks observed in Phanteon and their own recommendations. Context: http://chat/room/AAAAxKxTk40/jaP6Lj6fhmQ/jaP6Lj6fhmQ https://crbug.com/1444522 http://b/289992821
…nstead of removing
alan-agius4
force-pushed
the
perf-dom-renderer-remove-css
branch
from
cc84960 to
b944f4f
Compare
|
@AndrewKushnir, as mentioned offline, I had to re-add CSS removal/disabling for components that use view encapsulation. This is because a number of components in G3 use |
|
NOTE: TGP is green after deflaking. |
alan-agius4
removed
the
action: presubmit
AndrewKushnir
approved these changes
Sep 21, 2023
alan-agius4
removed
the
action: review
alan-agius4
added
action: merge
|
This PR was merged into the repository by commit 3c0577f. |
14 tasks
mattlewis92
pushed a commit
to mattlewis92/angular
that referenced
this pull request
Oct 5, 2023
…of removing (angular#51808) This commit changes the behaviour of `REMOVE_STYLES_ON_COMPONENT_DESTROY`. Now, `style` nodes are disabled instead of removed from DOM. This causes the same runtime behaviour but avoids recomputations when the stylesheet is re-added when the component is re-created. https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/css_style_sheet.h;l=266;drc=31fb07c05718d671d96c227855bfe97af9e3fb20 NB: This changes is being done following some performance bottlenecks observed in Phanteon and their own recommendations. Context: http://chat/room/AAAAxKxTk40/jaP6Lj6fhmQ/jaP6Lj6fhmQ https://crbug.com/1444522 http://b/289992821 PR Close angular#51808
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Oct 17, 2023
…instead of removing (angular#51808)" This reverts commit 65786b2 due to an oberved perf regression in Pantheon. See: http://b/303667704
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Oct 18, 2023
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Oct 18, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…of removing (angular#51808) This commit changes the behaviour of `REMOVE_STYLES_ON_COMPONENT_DESTROY`. Now, `style` nodes are disabled instead of removed from DOM. This causes the same runtime behaviour but avoids recomputations when the stylesheet is re-added when the component is re-created. https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/css_style_sheet.h;l=266;drc=31fb07c05718d671d96c227855bfe97af9e3fb20 NB: This changes is being done following some performance bottlenecks observed in Phanteon and their own recommendations. Context: http://chat/room/AAAAxKxTk40/jaP6Lj6fhmQ/jaP6Lj6fhmQ https://crbug.com/1444522 http://b/289992821 PR Close angular#51808
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the behaviour of
REMOVE_STYLES_ON_COMPONENT_DESTROY.Now,
stylenodes are disabled instead of removed from DOM. This causes the same runtime behaviour but avoids recomputations when the stylesheet is re-added when the component is re-created. https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/css_style_sheet.h;l=266;drc=31fb07c05718d671d96c227855bfe97af9e3fb20NB: This changes is being done following some performance bottlenecks observed in Phanteon and their own recommendations.
Context:
http://chat/room/AAAAxKxTk40/jaP6Lj6fhmQ/jaP6Lj6fhmQ
https://crbug.com/1444522
http://b/289992821