fix(router): children of routes with loadComponent should not inherit… #52114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parent data by default When a route has loadComponent, its children should not inherit params and data unless paramsInheritanceStrategy is 'always'. fixes angular#52106 BREAKING CHANGE: Routes with `loadComponent` would incorrectly cause child routes to inherit their data by default. The default `paramsInheritanceStrategy` is `emptyOnly`. If parent data should be inherited in child routes, this should be manually set to `always`.
atscott
added
target: major
angular-robot
bot
added
the
detected: breaking change
AndrewKushnir
approved these changes
Oct 9, 2023
|
TGP has one failure but looks unrelated |
|
This PR was merged into the repository by commit 37df395. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
… parent data by default (angular#52114) When a route has loadComponent, its children should not inherit params and data unless paramsInheritanceStrategy is 'always'. fixes angular#52106 BREAKING CHANGE: Routes with `loadComponent` would incorrectly cause child routes to inherit their data by default. The default `paramsInheritanceStrategy` is `emptyOnly`. If parent data should be inherited in child routes, this should be manually set to `always`. PR Close angular#52114
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… parent data by default
When a route has loadComponent, its children should not inherit params and data unless paramsInheritanceStrategy is 'always'.
fixes #52106
BREAKING CHANGE: Routes with
loadComponentwould incorrectly cause child routes to inherit their data by default. The defaultparamsInheritanceStrategyisemptyOnly. If parent data should be inherited in child routes, this should be manually set toalways.