Skip to content

fix(compiler): compilation error when for loop block expression contains new line #52447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(compiler): compilation error when for loop block expression contains new line #52447

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Fixes that the regex which captures the expression of a @for loop block wasn't accounting for line breaks.

Fixes #52446.

@crisbeto
fix(compiler): compilation error when for loop block expression conta…
7e0576b 
…ins new line

Fixes that the regex which captures the expression of a `@for` loop block wasn't accounting for line breaks.

Fixes angular#52446.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate labels Oct 30, 2023
@ngbot ngbot bot modified the milestone: Backlog Oct 30, 2023
@crisbeto crisbeto modified the milestones: Backlog, v17-final Oct 30, 2023
@crisbeto crisbeto removed the request for review from AndrewKushnir October 30, 2023 10:30
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 30, 2023
@alxhub
Copy link
Member

alxhub commented Oct 31, 2023

This PR was merged into the repository by commit b5ef68f.

@alxhub alxhub closed this in b5ef68f Oct 31, 2023
alxhub pushed a commit that referenced this pull request Oct 31, 2023
@crisbeto @alxhub
fix(compiler): compilation error when for loop block expression conta…
6c58252 
…ins new line (#52447)

Fixes that the regex which captures the expression of a `@for` loop block wasn't accounting for line breaks.

Fixes #52446.

PR Close #52447
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@crisbeto @ChellappanRajan
fix(compiler): compilation error when for loop block expression conta…
f0396ac 
…ins new line (angular#52447)

Fixes that the regex which captures the expression of a `@for` loop block wasn't accounting for line breaks.

Fixes angular#52446.

PR Close angular#52447
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
v17-final
Development

Successfully merging this pull request may close these issues.

Control flow: @for and inline arrays with multiple lines
3 participants
@crisbeto @alxhub @pkozlowski-opensource