Skip to content

Minor improvements around the version class #53598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Minor improvements around the version class #53598

wants to merge 2 commits into from

Conversation

crisbeto
Copy link
Member

Some minor improvements that avoid a bit of duplicated work and allow us to tree shake away the Version class.

@crisbeto
fix(core): avoid repeated work when parsing version
3aa9bcb 
The `Version` class was splitting the same value 3 times instead of doing it once and reusing the result.
@crisbeto
fix(core): tree shake version class
4912ce2 
Core bundles were retaining the `Version` class and `VERSION` constant, because we stamp out the current version in the DOM. This shouldn't be necessary, because any usage of `0.0.0-PLACEHOLDER` will be replaced with the current version at build time. These changes remove the reference so it can be tree shaken away.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Dec 16, 2023
@ngbot ngbot bot added this to the Backlog milestone Dec 16, 2023
@crisbeto crisbeto removed the request for review from jessicajaniuk December 17, 2023 20:09
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 17, 2023
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 872e7f2.

jessicajaniuk pushed a commit that referenced this pull request Dec 18, 2023
@crisbeto @thePunderWoman
fix(core): tree shake version class (#53598)
872e7f2 
Core bundles were retaining the `Version` class and `VERSION` constant, because we stamp out the current version in the DOM. This shouldn't be necessary, because any usage of `0.0.0-PLACEHOLDER` will be replaced with the current version at build time. These changes remove the reference so it can be tree shaken away.

PR Close #53598
jessicajaniuk pushed a commit that referenced this pull request Dec 18, 2023
@crisbeto @thePunderWoman
fix(core): avoid repeated work when parsing version (#53598)
d794892 
The `Version` class was splitting the same value 3 times instead of doing it once and reusing the result.

PR Close #53598
jessicajaniuk pushed a commit that referenced this pull request Dec 18, 2023
@crisbeto @thePunderWoman
fix(core): tree shake version class (#53598)
513fee8 
Core bundles were retaining the `Version` class and `VERSION` constant, because we stamp out the current version in the DOM. This shouldn't be necessary, because any usage of `0.0.0-PLACEHOLDER` will be replaced with the current version at build time. These changes remove the reference so it can be tree shaken away.

PR Close #53598
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 18, 2024
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@crisbeto @ChellappanRajan
fix(core): avoid repeated work when parsing version (angular#53598)
60852e0 
The `Version` class was splitting the same value 3 times instead of doing it once and reusing the result.

PR Close angular#53598
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@crisbeto @ChellappanRajan
fix(core): tree shake version class (angular#53598)
b23cc01 
Core bundles were retaining the `Version` class and `VERSION` constant, because we stamp out the current version in the DOM. This shouldn't be necessary, because any usage of `0.0.0-PLACEHOLDER` will be replaced with the current version at build time. These changes remove the reference so it can be tree shaken away.

PR Close angular#53598
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@crisbeto @rlmestre
fix(core): avoid repeated work when parsing version (angular#53598)
2b72a2f 
The `Version` class was splitting the same value 3 times instead of doing it once and reusing the result.

PR Close angular#53598
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@crisbeto @rlmestre
fix(core): tree shake version class (angular#53598)
b5456ba 
Core bundles were retaining the `Version` class and `VERSION` constant, because we stamp out the current version in the DOM. This shouldn't be necessary, because any usage of `0.0.0-PLACEHOLDER` will be replaced with the current version at build time. These changes remove the reference so it can be tree shaken away.

PR Close angular#53598
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@crisbeto @amilamen
fix(core): avoid repeated work when parsing version (angular#53598)
7219d02 
The `Version` class was splitting the same value 3 times instead of doing it once and reusing the result.

PR Close angular#53598
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@crisbeto @amilamen
fix(core): tree shake version class (angular#53598)
32f24fe 
Core bundles were retaining the `Version` class and `VERSION` constant, because we stamp out the current version in the DOM. This shouldn't be necessary, because any usage of `0.0.0-PLACEHOLDER` will be replaced with the current version at build time. These changes remove the reference so it can be tree shaken away.

PR Close angular#53598
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jessicajaniuk @devversion