refactor(core): signals toString improvements #54079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to angular#54002 that: * Remove the `toString` implementation from the `primitives`. * Guards the `toString` with `ngDevMode` and prints out the value.
crisbeto
added
action: review
alxhub
approved these changes
Jan 25, 2024
crisbeto
added
action: merge
|
Caretaker note: passes presubmit except for an unrelated flaky target. |
|
This PR was merged into the repository by commit c637dfa. |
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
Follow-up to angular#54002 that: * Remove the `toString` implementation from the `primitives`. * Guards the `toString` with `ngDevMode` and prints out the value. PR Close angular#54079
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
Follow-up to angular#54002 that: * Remove the `toString` implementation from the `primitives`. * Guards the `toString` with `ngDevMode` and prints out the value. PR Close angular#54079
nikvarma
pushed a commit
to nikvarma/angular
that referenced
this pull request
Jan 31, 2024
Follow-up to angular#54002 that: * Remove the `toString` implementation from the `primitives`. * Guards the `toString` with `ngDevMode` and prints out the value. PR Close angular#54079
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #54002 that:
toStringimplementation from theprimitives.toStringwithngDevModeand prints out the value.