Skip to content

Revert "fix(compiler-cli): forbid custom/duplicate decorator when opt… #54264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Revert "fix(compiler-cli): forbid custom/duplicate decorator when opt… #54264

wants to merge 3 commits into from

Conversation

jessicajaniuk
Copy link
Contributor

…ion forbidOrphanComponents is set (#54139)"

This reverts commit 96bcf4f.

@thePunderWoman
Revert "fix(compiler-cli): forbid custom/duplicate decorator when opt…
c6ba2f5 
…ion `forbidOrphanComponents` is set (angular#54139)"

This reverts commit 96bcf4f.
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Feb 5, 2024
@pullapprove pullapprove bot requested review from crisbeto February 5, 2024 18:10
@dylhunn dylhunn self-requested a review February 5, 2024 18:15
@jessicajaniuk jessicajaniuk added PullApprove: disable and removed action: review The PR is still awaiting reviews from at least one requested reviewer PullApprove: disable labels Feb 5, 2024
jessicajaniuk pushed a commit that referenced this pull request Feb 5, 2024
@thePunderWoman
Revert "fix(compiler-cli): allow custom/duplicate decorators for @Inj…
bd43aa3 
…ectable classes in local compilation mode (#54139)" (#54264)

This reverts commit a592904.

PR Close #54264
jessicajaniuk pushed a commit that referenced this pull request Feb 5, 2024
@thePunderWoman
Revert "fix(compiler-cli): consider the case of duplicate Angular dec…
e46c081 
…orators in local compilation diagnostics (#54139)" (#54264)

This reverts commit 4b1d948.

PR Close #54264
@jessicajaniuk
Copy link
Contributor Author

This PR was merged into the repository by commit e46c081.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto

1 more reviewer

@dylhunn dylhunn dylhunn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker PullApprove: disable target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessicajaniuk @dylhunn @thePunderWoman