Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(platform-browser-dynamic): unused RESOURCE_CACHE_PROVIDER API has been removed #54875

Closed
wants to merge 1 commit into from
Closed

refactor(platform-browser-dynamic): unused RESOURCE_CACHE_PROVIDER API has been removed #54875

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

BREAKING CHANGE: No longer used RESOURCE_CACHE_PROVIDER APIs have been removed.

@alan-agius4
refactor(platform-browser-dynamic): unused RESOURCE_CACHE_PROVIDER …
da0890b 
…API has been removed

BREAKING CHANGE: No longer used `RESOURCE_CACHE_PROVIDER` APIs have been removed.
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Mar 15, 2024
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 15, 2024
@alan-agius4 alan-agius4 marked this pull request as ready for review March 15, 2024 10:39
@alan-agius4 alan-agius4 added the refactoring Issue that involves refactoring or code-cleanup label Mar 15, 2024
AndrewKushnir
AndrewKushnir approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from atscott March 15, 2024 22:35
alxhub
alxhub approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 15, 2024
@alxhub
Copy link
Member

alxhub commented Mar 18, 2024

This PR was merged into the repository by commit eb20c1a.

@alxhub alxhub closed this in eb20c1a Mar 18, 2024
@alan-agius4 alan-agius4 deleted the platform-dynamic-dep branch March 19, 2024 06:39
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@alan-agius4 @ilirbeqirii
refactor(platform-browser-dynamic): unused RESOURCE_CACHE_PROVIDER …
82e9749 
…API has been removed (angular#54875)

BREAKING CHANGE: No longer used `RESOURCE_CACHE_PROVIDER` APIs have been removed.

PR Close angular#54875
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker detected: breaking change PR contains a commit with a breaking change refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alan-agius4 @alxhub @AndrewKushnir