-
Notifications
You must be signed in to change notification settings - Fork 26.5k
fix(forms): Allow canceled async validators to emit. #55134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
52881d0
to
530de42
Compare
dce644f
to
51b700f
Compare
Matthieu and i spent some time yesterday looking at the failures, and they mostly originate with various teams using |
Talking to a possible owner of a failing test in g3, in order to get some help fixing the test. |
96fe757
to
5160e41
Compare
Since this change is a bit too breaking to land in G3, I'm looking at a solution that will only work with the new |
5160e41
to
3e1d02b
Compare
With this change, If an async validator that should have emitted was cancelled by a non-emitting validator, the status change will be reported on the `AbstractControl.events` observable. This issue can happen when a `FormControl` is added to a `FormGroup` and a FormGroupDirective/FormControlDirective trigger a non-emitting validation (which cancels the initial validator execution). Note: The behavior remains the same of the existing `statusChanges` observable as the change was too breaking to land in G3. fixes: angular#41519
3e1d02b
to
d61efeb
Compare
caretaker: this has a clean TGP (https://test.corp.google.com/OCL:630752820:BASE:630752881:1714884722829:6f76c7bc) |
This PR was merged into the repository by commit 53b0d6a. |
With this change, If an async validator that should have emitted was cancelled by a non-emitting validator, the status change will be reported on the `AbstractControl.events` observable. This issue can happen when a `FormControl` is added to a `FormGroup` and a FormGroupDirective/FormControlDirective trigger a non-emitting validation (which cancels the initial validator execution). Note: The behavior remains the same of the existing `statusChanges` observable as the change was too breaking to land in G3. fixes: #41519 PR Close #55134
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
With this change, If an async validator that should have emitted was cancelled by a non-emitting validator, the status change will be reported on the
AbstractControl.events
observable.This issue can happen when a
FormControl
is added to aFormGroup
and a FormGroupDirective/FormControlDirective trigger a non-emitting validation (which cancels the initial validator execution).Note: The behavior remains the same of the existing
statusChanges
observable as the change was too breaking to land in G3.fixes: #41519