fix(core): TestBed should not override NgZone from initTestEnvironment #55226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, `NgZone` was provided by default in TestBed in a location that would override anything configured in `TestBed.initTestEnvironment`. This change moves the default `NgZone` provider to the `RootScopeModule` and these providers can be overridden by the ones in `additionalModuleTypes`, which are assigned from the first argument of `initTestEnvironment`. This makes it possible to configure Zone globally for all tests as opposed to needing to repeat it in `configureTestingModule` of each suite.
thePunderWoman
added
the
area: testing
thePunderWoman
added
the
action: review
AndrewKushnir
approved these changes
Apr 5, 2024
AndrewKushnir
removed
the
action: review
|
This PR was merged into the repository by commit e9a0c86. |
atscott
added a commit
to atscott/angular
that referenced
this pull request
Apr 10, 2024
…vironment (angular#55226)" This reverts commit e9a0c86. flakes and broken tests. needs more investigation.
atscott
added a commit
that referenced
this pull request
Apr 10, 2024
atscott
added
requires: TGP
pullapprove
bot
added
target: minor
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 11, 2024
angular#55226) Prior to this change, `NgZone` was provided by default in TestBed in a location that would override anything configured in `TestBed.initTestEnvironment`. This change moves the default `NgZone` provider to the `RootScopeModule` and these providers can be overridden by the ones in `additionalModuleTypes`, which are assigned from the first argument of `initTestEnvironment`. This makes it possible to configure Zone globally for all tests as opposed to needing to repeat it in `configureTestingModule` of each suite. PR Close angular#55226
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 11, 2024
…vironment (angular#55226)" (angular#55286) This reverts commit e9a0c86. flakes and broken tests. needs more investigation. PR Close angular#55286
atscott
added
state: blocked
requires: TGP
pullapprove
bot
removed
the
requires: TGP
atscott
added
the
requires: TGP
pullapprove
bot
removed
the
requires: TGP
|
TESTED=TGP |
atscott
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
atscott
added
the
merge: caretaker note
|
merge assistance: green TGP. |
atscott
added
action: merge
|
This PR was merged into the repository by commit 7330b69. |
AndrewKushnir
pushed a commit
that referenced
this pull request
May 6, 2024
#55226) Prior to this change, `NgZone` was provided by default in TestBed in a location that would override anything configured in `TestBed.initTestEnvironment`. This change moves the default `NgZone` provider to the `RootScopeModule` and these providers can be overridden by the ones in `additionalModuleTypes`, which are assigned from the first argument of `initTestEnvironment`. This makes it possible to configure Zone globally for all tests as opposed to needing to repeat it in `configureTestingModule` of each suite. PR Close #55226
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change,
NgZonewas provided by default in TestBed in a location that would override anything configured inTestBed.initTestEnvironment. This change moves the defaultNgZoneprovider to theRootScopeModuleand these providers can be overridden by the ones inadditionalModuleTypes, which are assigned from the first argument ofinitTestEnvironment. This makes it possible to configure Zone globally for all tests as opposed to needing to repeat it inconfigureTestingModuleof each suite.