fix(language-service): implement getDefinitionAtPosition for Angular templates #55269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…templates The `getDefinitionAtPosition` function may be called by consumers instead of `getDefinitionAndBoundSpan` with the later of which already implemented. The `getDefinitionAtPosition` result is a subset of what `getDefinitionAndBoundSpan` returns and currently delegates to that function.
clydin
added
action: review
atscott
approved these changes
Apr 9, 2024
atscott
added
action: merge
|
This PR was merged into the repository by commit bd236cc. |
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 11, 2024
…templates (angular#55269) The `getDefinitionAtPosition` function may be called by consumers instead of `getDefinitionAndBoundSpan` with the later of which already implemented. The `getDefinitionAtPosition` result is a subset of what `getDefinitionAndBoundSpan` returns and currently delegates to that function. PR Close angular#55269
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getDefinitionAtPositionfunction may be called by consumers instead ofgetDefinitionAndBoundSpanwith the later of which already implemented. ThegetDefinitionAtPositionresult is a subset of whatgetDefinitionAndBoundSpanreturns and currently delegates to that function.