Skip to content

feat(core): Modify EventType from an enum to an object. #55323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

iteriani
Copy link
Contributor

@iteriani iteriani commented Apr 12, 2024

This is needed to reduce the binary size of the event contract.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Apr 12, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 12, 2024
@iteriani iteriani requested a review from tbondwilkinson April 12, 2024 18:21
This is needed to reduce the binary size of the event contract.
@iteriani iteriani removed the request for review from ehlemur April 12, 2024 18:26
@iteriani iteriani added the area: core Issues related to the framework runtime label Apr 14, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 14, 2024
@iteriani iteriani added the target: major This PR is targeted for the next major release label Apr 14, 2024
@iteriani iteriani added the action: merge The PR is ready for merge by the caretaker label Apr 15, 2024
@pkozlowski-opensource
Copy link
Member

TGP - deflaked, "green" (as far as I can tell failrues are unrelated)

@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit d28614b.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit requires: TGP This PR requires a passing TGP before merging is allowed target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants