Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): add optional rounded transform support in cloudinary image loader #55364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devashishSarmah
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently, the cloudinary image loader doesn't support rounded transform

Issue Number: N/A

What is the new behavior?

Added a change which enables the users to add a prop called rounded to the existing ImageLoaderConfig.loaderParams prop.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from dylhunn April 16, 2024 15:27
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 16, 2024
@pkozlowski-opensource pkozlowski-opensource added the area: common Issues related to APIs in the @angular/common package label Apr 16, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 16, 2024
…age loader

Currently, the cloudinary image loader doesn't support rounded transform.
Add a new prop called `rounded` to the existing `ImageLoaderConfig.loaderParams`
@devashishSarmah devashishSarmah force-pushed the image-loader-cloudinary-add-rounded-transform branch from ac6c240 to 3ed3fc4 Compare April 17, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: common Issues related to APIs in the @angular/common package detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants