fix(migrations): handle empty ngSwitchCase

[naaajii]

empty ngSwitchCase generate case () { which isn't valid syntax therefore adding quotes will help prevent us migrate empty case if no condition was provided

fix #56030

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Issue Number: #56030

control flow cases being generated with no fallback value in them

What is the new behavior?

control flow cases contain single quotes if ngSwitchCase didnt had any value in it

Does this PR introduce a breaking change?

• Yes
• No

Other information

[JeanMeche]

Do you mind bringing in the test you had in #56103, thank you ?

[naaajii]

main branch didnt contain test file for control flow migration, so im not sure where that test would go.

[JeanMeche]

Oh it looks like the file was (mistakenly ?) removed in #55391
@jessicajaniuk should we restore it ?

[naaajii]

isnt it more like we dont need those tests anymore as it just works - like we wouldnt be needing that migration in v18 as it was for migrating from v17 to v18, now we are just providing fixes for missing cases? apologies if i misunderstood something!

take my word for it, it works on my PC! 😀

[JoostK]

Definitely those tests need to be restored!

[JeanMeche]

This migration was optional in v17 as control flow was still in developer preview.
We like to have a test coverage for migrations to cover for potential regressions in future changes in the migrations.

[naaajii]

should i bring them back in this branch or create new one?

[thePunderWoman]

I'll create a PR to restore the tests.

[thePunderWoman]

Looks like @alan-agius4 beat me to it with #56130.

[thePunderWoman]

@naaajii the PR restoring the tests has been merged. Can you rebase and add your test case?

[naaajii]

done!

[thePunderWoman]

LGTM! Thanks for updating this!

[pkozlowski-opensource]

This PR was merged into the repository by commit 3b2f88c.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}