fix(benchpress): adjust supported browser names for headless chrome [fixit]

[pkozlowski-opensource]

The chrome version controlled by selenium reports chrome-headless-shell in the current setup. This fix accounts for the updated browser name.

[pkozlowski-opensource]

@devversion I'm not sure if this is the right place to fix but it looks like SeleniumWebDriverAdapter started to report a different browser name under the current setup. I'm not sure what changed exactly but the browser name seems to be taken from the selenium web driver capabilities.

[devversion]

@pkozlowski-opensource it seems like a reasonable change, but I'm not aware of the issue. What's the issue we are seeing right now?

[pkozlowski-opensource]

it seems like a reasonable change, but I'm not aware of the issue. What's the issue we are seeing right now?

@devversion any benchmark at main fails to start now with the:

 Error: Could not find a delegate for given capabilities!
        at Object.useFactory (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/benchpress/src/web_driver_extension.mjs:33:31)
        at Object.factory (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/r3_injector.mjs:433:38)
        at file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/r3_injector.mjs:330:47
        at runInInjectorProfilerContext (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/render3/debug/injector_profiler.mjs:115:9)
        at R3Injector.hydrate (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/r3_injector.mjs:329:21)
        at R3Injector.get (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/r3_injector.mjs:192:33)
        at injectInjectorOnly (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/injector_compatibility.mjs:52:40)
        at ɵɵinject (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/injector_compatibility.mjs:58:61)
        at injectArgs (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/injector_compatibility.mjs:189:23)
        at Object.factory (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/r3_injector.mjs:445:49)
    From: Task: Run it("should run benchmark for ng2") in control flow
        at UserContext.<anonymous> (/private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/jasminewd2/index.js:94:19)
        at /private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/jasminewd2/index.js:64:48
        at ControlFlow.emit (/private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/protractor/node_modules/selenium-webdriver/lib/events.js:62:21)
        at ControlFlow.shutdown_ (/private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:2674:10)
        at /private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:2599:53
    From asynchronous test: 
    Error
        at Suite.<anonymous> (/private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/modules/benchmarks/src/js-web-frameworks/js-web-frameworks.perf-spec.ts:72:7)
        at /private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/modules/benchmarks/src/js-web-frameworks/js-web-frameworks.perf-spec.ts:71:5
        at Array.forEach (<anonymous>)
        at Suite.<anonymous> (/private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/modules/benchmarks/src/js-web-frameworks/js-web-frameworks.perf-spec.ts:70:76)

and the root cause I've tracked down is to the change in the browser name we are getting from the getCapabilities call.

[devversion]

Confirming that I reproduce the same in main. I would fix this similarly. LGTM!

[AndrewKushnir]

This PR was merged into the repository by commit 31d9fa4.

The changes were merged into the following branches: main, 18.0.x

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}