Skip to content

fix(benchpress): adjust supported browser names for headless chrome [fixit] #56360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(benchpress): adjust supported browser names for headless chrome [fixit] #56360

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

The chrome version controlled by selenium reports chrome-headless-shell in the current setup. This fix accounts for the updated browser name.

@pkozlowski-opensource
fix(benchpress): adjust supported browser names for headless chrome
0d19223 
The chrome version controlled by selenium reports chrome-headless-shell in the
current setup. This fix accounts for the updated browser name.
@pkozlowski-opensource pkozlowski-opensource added area: benchpress action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 10, 2024
@ngbot ngbot bot modified the milestone: Backlog Jun 10, 2024
@pkozlowski-opensource
Copy link
Member Author

pkozlowski-opensource commented Jun 10, 2024 •
edited
Loading

@devversion I'm not sure if this is the right place to fix but it looks like SeleniumWebDriverAdapter started to report a different browser name under the current setup. I'm not sure what changed exactly but the browser name seems to be taken from the selenium web driver capabilities.

@pkozlowski-opensource pkozlowski-opensource changed the title fix(benchpress): adjust supported browser names for headless chrome fix(benchpress): adjust supported browser names for headless chrome [fixit] Jun 10, 2024
@devversion
Copy link
Member

@pkozlowski-opensource it seems like a reasonable change, but I'm not aware of the issue. What's the issue we are seeing right now?

@pkozlowski-opensource
Copy link
Member Author

it seems like a reasonable change, but I'm not aware of the issue. What's the issue we are seeing right now?

@devversion any benchmark at main fails to start now with the:

 Error: Could not find a delegate for given capabilities!
        at Object.useFactory (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/benchpress/src/web_driver_extension.mjs:33:31)
        at Object.factory (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/r3_injector.mjs:433:38)
        at file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/r3_injector.mjs:330:47
        at runInInjectorProfilerContext (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/render3/debug/injector_profiler.mjs:115:9)
        at R3Injector.hydrate (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/r3_injector.mjs:329:21)
        at R3Injector.get (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/r3_injector.mjs:192:33)
        at injectInjectorOnly (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/injector_compatibility.mjs:52:40)
        at ɵɵinject (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/injector_compatibility.mjs:58:61)
        at injectArgs (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/injector_compatibility.mjs:189:23)
        at Object.factory (file:///private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/@angular/core/src/di/r3_injector.mjs:445:49)
    From: Task: Run it("should run benchmark for ng2") in control flow
        at UserContext.<anonymous> (/private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/jasminewd2/index.js:94:19)
        at /private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/jasminewd2/index.js:64:48
        at ControlFlow.emit (/private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/protractor/node_modules/selenium-webdriver/lib/events.js:62:21)
        at ControlFlow.shutdown_ (/private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:2674:10)
        at /private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/ng2/perf_chromium.sh.runfiles/angular/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:2599:53
    From asynchronous test: 
    Error
        at Suite.<anonymous> (/private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/modules/benchmarks/src/js-web-frameworks/js-web-frameworks.perf-spec.ts:72:7)
        at /private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/modules/benchmarks/src/js-web-frameworks/js-web-frameworks.perf-spec.ts:71:5
        at Array.forEach (<anonymous>)
        at Suite.<anonymous> (/private/var/tmp/_bazel_pkozlowski/830f18d1097b3fc04ad901aea9620eb0/sandbox/darwin-sandbox/86/execroot/angular/bazel-out/darwin_arm64-fastbuild/bin/modules/benchmarks/src/js-web-frameworks/modules/benchmarks/src/js-web-frameworks/js-web-frameworks.perf-spec.ts:70:76)

and the root cause I've tracked down is to the change in the browser name we are getting from the getCapabilities call.

devversion
devversion approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that I reproduce the same in main. I would fix this similarly. LGTM!

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 10, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 31d9fa4.

The changes were merged into the following branches: main, 18.0.x

AndrewKushnir pushed a commit that referenced this pull request Jun 11, 2024
@pkozlowski-opensource @AndrewKushnir
fix(benchpress): adjust supported browser names for headless chrome (#…
ebf00aa 
…56360)

The chrome version controlled by selenium reports chrome-headless-shell in the
current setup. This fix accounts for the updated browser name.

PR Close #56360
@crokenx crokenx mentioned this pull request Jul 3, 2024
Open
@sixcorners sixcorners mentioned this pull request Jul 4, 2024
Closed
@hantsy hantsy mentioned this pull request Jul 4, 2024
Closed
@juanponton5 juanponton5 mentioned this pull request Jul 4, 2024
Open
@ambrose40 ambrose40 mentioned this pull request Jul 4, 2024
Open
This was referenced Jul 4, 2024
Open
Open
Open
@MrDari MrDari mentioned this pull request Jul 5, 2024
Open
@hantsy hantsy mentioned this pull request Jul 10, 2024
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: benchpress target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@pkozlowski-opensource @devversion @AndrewKushnir