Skip to content

docs: Update structural-directives.md #56753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

harishkrishnan24
Copy link
Contributor

@harishkrishnan24 harishkrishnan24 commented Jun 28, 2024

A Grammatical error in the section - "Type narrowing with template guards"

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from crisbeto June 28, 2024 12:56
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jun 28, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 28, 2024
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this !

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 28, 2024
@JeanMeche JeanMeche requested review from JeanMeche and removed request for crisbeto June 28, 2024 12:57
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this !

@JeanMeche JeanMeche added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jun 28, 2024
@JeanMeche
Copy link
Member

Could you please squash your commits into a single one. Thank you.

@JeanMeche
Copy link
Member

You added 2 commits with that merge, this PR should be a single commit.

@harishkrishnan24
Copy link
Contributor Author

You added 2 commits with that merge, this PR should be a single commit.

yeah sorry. Fixing it up

@harishkrishnan24
Copy link
Contributor Author

@JeanMeche done. Squashed the commits

@bencodezen bencodezen added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 28, 2024
thePunderWoman pushed a commit that referenced this pull request Jul 1, 2024
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit aad3c2d.

The changes were merged into the following branches: main, 18.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants