Skip to content

ci: add myself as an aio reviewer #56829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Jul 3, 2024

This is to allow myself to approve minor aio changes like redirections.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jul 3, 2024
@ngbot ngbot bot added this to the Backlog milestone Jul 3, 2024
@JeanMeche JeanMeche closed this Jul 9, 2024
@JeanMeche JeanMeche reopened this Jul 11, 2024
This is to allow myself to approve minor aio changes like redirections.
@JeanMeche JeanMeche force-pushed the docs/pullapprove-aio branch from 1ee9159 to 7359ee5 Compare July 11, 2024 12:22
@JeanMeche JeanMeche marked this pull request as ready for review July 11, 2024 12:23
@pullapprove pullapprove bot requested a review from thePunderWoman July 11, 2024 12:23
@JeanMeche JeanMeche added the target: lts This PR is targeting a version currently in long-term support label Jul 11, 2024
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: lts This PR is targeting a version currently in long-term support target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jul 11, 2024
@thePunderWoman
Copy link
Contributor

@JeanMeche I don't think this PR is necessary. Pullapprove rules are only relevant in main.

@JeanMeche JeanMeche closed this Jul 11, 2024
@JeanMeche JeanMeche deleted the docs/pullapprove-aio branch July 11, 2024 16:06
@JeanMeche JeanMeche restored the docs/pullapprove-aio branch July 12, 2024 14:36
@JeanMeche
Copy link
Member Author

I've reopened the PR since it appears that the branch does matter for the pullapprove rule check.

@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Jul 12, 2024
@ngbot
Copy link

ngbot bot commented Jul 12, 2024

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@JeanMeche JeanMeche added target: lts This PR is targeting a version currently in long-term support and removed target: minor This PR is targeted for the next minor release labels Jul 12, 2024
@thePunderWoman thePunderWoman added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jul 12, 2024
@thePunderWoman
Copy link
Contributor

Caretaker note: mergeability always fails on PRs that target lts. So this is safe to merge.

atscott pushed a commit that referenced this pull request Jul 18, 2024
This is to allow myself to approve minor aio changes like redirections.

PR Close #56829
@atscott
Copy link
Contributor

atscott commented Jul 18, 2024

This PR was merged into the repository by commit 45c1326.

The changes were merged into the following branches: 17.3.x

@atscott atscott closed this Jul 18, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: lts This PR is targeting a version currently in long-term support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants