Various improvements for the signal input migration #57318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
area: performance
…ompatibility reasons Adds a markdown document capturing some of the incompatibilty reasons on why the input wasn't migrated.
Introduces a best effort mode for the signal input migration. This mode can be used to aggresively migrate as much as possible, ignoring most of the incompatibility reasons, like "writes to the input".
Instead of fiddling manually with the imports, which worked well, but comes at a cost of complexity— we are now using the canonical import manager. This simplifies deletion, insertion and updating of imports. Notably, our import manager is not super great at preserving whitespaces right now, but we assume a formatter runs over migrated code anyway.
…alyze phases Instead of revisiting each source file, and each of its child nodes twice, we now visit them together using a grouped AST visitor that only traverses each source file once. This seemed to speed up migration by 6-8% locally, but is likely noticable better with large compilation scopes.
devversion
force-pushed
the
signal-migration-improv
branch
2 times, most recently
from
d9b45e0 to
ba116c7
Compare
…ation As of this commit, the migration will also inspect safe property reads and migrate them, if they reference an input that is being migrated.
devversion
force-pushed
the
signal-migration-improv
branch
from
ba116c7 to
4b998a4
Compare
crisbeto
approved these changes
Aug 12, 2024
devversion
added
action: merge
devversion
added
target: rc
|
This PR was merged into the repository by commit 52673e6. The changes were merged into the following branches: main, 18.2.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 12, 2024
…57318) Instead of fiddling manually with the imports, which worked well, but comes at a cost of complexity— we are now using the canonical import manager. This simplifies deletion, insertion and updating of imports. Notably, our import manager is not super great at preserving whitespaces right now, but we assume a formatter runs over migrated code anyway. PR Close #57318
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 12, 2024
…alyze phases (#57318) Instead of revisiting each source file, and each of its child nodes twice, we now visit them together using a grouped AST visitor that only traverses each source file once. This seemed to speed up migration by 6-8% locally, but is likely noticable better with large compilation scopes. PR Close #57318
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 12, 2024
…57318) Instead of fiddling manually with the imports, which worked well, but comes at a cost of complexity— we are now using the canonical import manager. This simplifies deletion, insertion and updating of imports. Notably, our import manager is not super great at preserving whitespaces right now, but we assume a formatter runs over migrated code anyway. PR Close #57318
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 12, 2024
…alyze phases (#57318) Instead of revisiting each source file, and each of its child nodes twice, we now visit them together using a grouped AST visitor that only traverses each source file once. This seemed to speed up migration by 6-8% locally, but is likely noticable better with large compilation scopes. PR Close #57318
This was referenced Aug 28, 2024
This was referenced Sep 4, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Based on top of #57308