Skip to content

refactor(compiler): update dependency chokidar to v4 #57945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(compiler): update dependency chokidar to v4 #57945

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

Superseding #57797

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Sep 24, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 24, 2024
@JeanMeche JeanMeche marked this pull request as ready for review September 25, 2024 15:27
@JeanMeche JeanMeche added the target: patch This PR is targeted for the next patch release label Sep 25, 2024
@JeanMeche JeanMeche mentioned this pull request Sep 25, 2024
Closed
1 task
devversion
devversion approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Matthieu. Maybe it's actually a refactor: for compiler? or feat?

@JeanMeche JeanMeche force-pushed the ng-renovate/chokidar-4-x branch from f7d8db9 to 0fdd9ad Compare September 26, 2024 10:20
@angular-robot angular-robot bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: build & ci Related the build and CI infrastructure of the project labels Sep 26, 2024
@JeanMeche JeanMeche changed the title build: update dependency chokidar to v4 refactor(compiler): update dependency chokidar to v4 Sep 26, 2024
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Sep 26, 2024
@JeanMeche JeanMeche force-pushed the ng-renovate/chokidar-4-x branch from 0fdd9ad to 5a56bd8 Compare September 26, 2024 21:57
@angular-robot angular-robot bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Sep 26, 2024
@ngbot ngbot bot modified the milestone: Backlog Sep 26, 2024
@JeanMeche JeanMeche force-pushed the ng-renovate/chokidar-4-x branch from 5a56bd8 to ab0f887 Compare September 26, 2024 23:04
@pullapprove pullapprove bot requested review from alxhub and dylhunn September 26, 2024 23:04
@angular-robot angular-robot bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Sep 26, 2024
@ngbot ngbot bot modified the milestone: Backlog Sep 26, 2024
@pullapprove pullapprove bot requested review from alxhub and dylhunn September 27, 2024 19:45
JoostK
JoostK reviewed Sep 27, 2024
View reviewed changes
@JeanMeche JeanMeche force-pushed the ng-renovate/chokidar-4-x branch from ab0f887 to e2cc3c0 Compare September 27, 2024 20:19
@angular-robot angular-robot bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Sep 27, 2024
@pullapprove pullapprove bot requested review from alxhub and dylhunn September 27, 2024 20:20
@ngbot ngbot bot modified the milestone: Backlog Sep 27, 2024
@devversion
Copy link
Member

@JeanMeche can you rebase? is this size tracking change already in main?

@angular-robot @JeanMeche
refactor(compiler): update dependency chokidar to v4
a4a7da1 
This commit bump chokidar to the latest major and adjusts to the breaking changes.
@JeanMeche JeanMeche force-pushed the ng-renovate/chokidar-4-x branch from e2cc3c0 to a4a7da1 Compare October 1, 2024 09:15
@angular-robot angular-robot bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 1, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit a2bdd6a.

The changes were merged into the following branches: main, 18.2.x

AndrewKushnir pushed a commit that referenced this pull request Oct 4, 2024
@angular-robot @AndrewKushnir
refactor(compiler): update dependency chokidar to v4 (#57945)
3fb696d 
This commit bump chokidar to the latest major and adjusts to the breaking changes.

PR Close #57945
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@JeanMeche @devversion @AndrewKushnir @JoostK @angular-robot