Skip to content

feat(language-service): support migrating full classes to signal queries #58263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat(language-service): support migrating full classes to signal queries #58263

wants to merge 2 commits into from

Conversation

devversion
Copy link
Member

See individual commits

@devversion
feat(language-service): support migrating full classes to signal queries
ee14b55 
Adds a similar code action as for inputs, where users can migrate full
classes to signal queries.
@devversion
refactor(language-service): improve name of input full class refactor…
d07117e 
…ing action

Prefixing the full class refactoring actions with `Full class` makes
them less confusing along with the individual field actions.
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Oct 18, 2024
@devversion devversion requested a review from crisbeto October 18, 2024 13:32
@pullapprove pullapprove bot requested a review from clydin October 18, 2024 13:32
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: language-service Issues related to Angular's VS Code language service labels Oct 18, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 18, 2024
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 18, 2024
@devversion
Copy link
Member Author

This PR was merged into the repository by commit c1432f9.

The changes were merged into the following branches: main

devversion added a commit that referenced this pull request Oct 18, 2024
@devversion
refactor(language-service): improve name of input full class refactor…
c1432f9 
…ing action (#58263)

Prefixing the full class refactoring actions with `Full class` makes
them less confusing along with the individual field actions.

PR Close #58263
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @crisbeto @clydin