feat(compiler): support the in keyword in Binary expression
#58432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: compiler
JeanMeche
commented
Oct 30, 2024
JeanMeche
requested review from
alxhub and
crisbeto
and removed request for
AndrewKushnir
JeanMeche
force-pushed
the
in-operator
branch
from
7b3832a to
e322d4a
Compare
angular-robot
bot
added
area: compiler
wartab
reviewed
Oct 30, 2024
JeanMeche
force-pushed
the
in-operator
branch
from
e322d4a to
1549ac7
Compare
angular-robot
bot
added
area: compiler
JeanMeche
force-pushed
the
in-operator
branch
3 times, most recently
from
4e8c96a to
8041fb9
Compare
JeanMeche
changed the title
in keyword in Binary expressionin keyword in Binary expression
JeanMeche
force-pushed
the
in-operator
branch
from
8041fb9 to
98fd4dc
Compare
angular-robot
bot
added
the
detected: breaking change
JeanMeche
removed
detected: feature
JeanMeche
force-pushed
the
in-operator
branch
from
98fd4dc to
6828640
Compare
angular-robot
bot
added
detected: breaking change
JeanMeche
force-pushed
the
in-operator
branch
2 times, most recently
from
7ff4cb0 to
b6c32c3
Compare
JeanMeche
force-pushed
the
in-operator
branch
4 times, most recently
from
8d47aae to
111aaff
Compare
crisbeto
approved these changes
Apr 22, 2025
packages/compiler-cli/src/ngtsc/typecheck/test/type_check_block_spec.ts
Outdated
Show resolved
Hide resolved
This commit adds the support for the `in` keyword as a relational operator, with the same precedence as the other relational operators (<,>, <=, >=) BREAKING CHANGE: 'in' in an expression now refers to the operator
JeanMeche
added
action: merge
|
This PR was merged into the repository by commit 1b8e7ab. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the support for the
inkeyword as a relational operator, with the same precedence as the other relational operators (<,>, <=, >=).As a bigger picture, adding this brings us toward