fix(platform-browser): roll back HMR fix #59557
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
Rolls back the changes from angular#59514 because they ended up being breaking in 1P. We can revisit the internal fix in a different way. Fixes angular#59558.
crisbeto
force-pushed
the
hmr-regression
branch
from
20304b5 to
bc33950
Compare
crisbeto
changed the title
pkozlowski-opensource
approved these changes
Jan 16, 2025
pkozlowski-opensource
added
action: merge
|
This PR was merged into the repository by commit 2fe54a1. The changes were merged into the following branches: main, 19.1.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jan 16, 2025
|
Thank you for handling this, and so responsively <3. I personally verified with a fork of my SB repro and it worked as intended. Very excited to proceed with my upgrade to the latest version now with this patch. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Rolls back the changes from angular#59514 because they ended up being breaking in 1P. We can revisit the internal fix in a different way. Fixes angular#59558. PR Close angular#59557
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls back the changes from #59514 because they ended up being breaking in 3P. We can revisit the internal fix in a different way.
Fixes #59558.