fix(compiler-cli): add suggestion when pipe is missing #62146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds some suggestions for potential pipes to be imported when raising the missing pipe diagnostic. Fixes angular#62136.
crisbeto
added
action: review
angular-robot
bot
added
the
area: compiler
crisbeto
commented
Jun 19, 2025
|
|
||
| if (isStandalone) { | ||
| errorMsg += | ||
| `\nTo fix this, import the "${suggestedClassName}" class from "${suggestedImport}"` + |
There was a problem hiding this comment.
I was pondering whether to also say something like "...or import it from your own codebase" here.
AndrewKushnir
approved these changes
Jun 19, 2025
crisbeto
added
action: merge
|
This PR was merged into the repository by commit ed5062a. The changes were merged into the following branches: main, 20.0.x |
crisbeto
added a commit
that referenced
this pull request
Jun 20, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some suggestions for potential pipes to be imported when raising the missing pipe diagnostic.
Fixes #62136.